Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
bda7adc449 | ||
|
|
aa88db50b2 | ||
|
|
c9b882aa46 | ||
|
|
6368365bd6 | ||
|
|
191c99b59b | ||
|
|
b7f8e1612c | ||
|
|
66aecc2bcb | ||
|
|
ccb9f6dce2 | ||
|
|
978c13358b |
No files matched your search
@@ -7,6 +7,70 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
|
||||
## [Unreleased]
|
||||
|
||||
## [2.18.0] - 2026-11-12
|
||||
|
||||
A tidier admin area.
|
||||
|
||||
### Added
|
||||
- **Log page** (`/admin/log`): everything that is failing right now, newest
|
||||
first. Each entry shows when it happened, what failed (crosspost, response
|
||||
check, outgoing webmention, reply-context fetch, WebSub delivery,
|
||||
notifications, refused silo credentials), a link to the affected post and
|
||||
the error message, with Retry / Check now where that applies. It reads the
|
||||
error columns the workers already keep, so an entry goes away once the
|
||||
next attempt succeeds. The admin nav shows the error count.
|
||||
- **Settings page** (`/admin/settings`) for site-wide settings. Notification
|
||||
status and the test button live here now.
|
||||
- Webmentions, Log and Settings links in the admin nav.
|
||||
|
||||
### Changed
|
||||
- The Webmentions page no longer has the Back to Dashboard button or the
|
||||
Notifications section, and links to the Log instead of counting response
|
||||
check errors.
|
||||
|
||||
## [2.17.1] - 2026-11-12
|
||||
|
||||
### Fixed
|
||||
|
||||
- Crossposting failed in 2.17.0 (never deployed): post URLs were built with Flask's `url_for`, which needs a web request, and crossposts run in a background worker. URLs are now built from `SITE_URL`
|
||||
|
||||
## [2.17.0] - 2026-11-12
|
||||
|
||||
Articles get URLs of their own (ADR-077).
|
||||
|
||||
### Changed
|
||||
|
||||
- Articles live at `/article/<slug>` instead of `/note/<slug>`. The other address redirects (301), so links keep working when a note gains or loses a title. Feeds, pages, Micropub, crossposts, webmentions, notifications, search and the MCP tools all give the new URLs
|
||||
- A new article's slug comes from its title (`Why I Left Twitter` → `why-i-left-twitter`; `-2` if taken). An `mp-slug` still wins, notes keep timestamp slugs, and slugs don't change when a title is edited later
|
||||
- A Micropub update that adds or removes a title answers 201 with the post's new URL in `Location`, as the spec requires
|
||||
|
||||
## [2.16.0] - 2026-11-11
|
||||
|
||||
Articles as the IndieWeb defines them: titles and summaries stored apart from the text (ADR-076).
|
||||
|
||||
**Before upgrading, back up the database and the `data` folder (notes and `.trash`).** Migration 023 moves each note's `# Heading` title out of its Markdown file into the database.
|
||||
|
||||
### Added
|
||||
|
||||
- Notes have a title and a summary of their own. A note with a title is an article. The editor has Title and Summary fields, and an article may have no body text
|
||||
- Micropub `summary` is stored when sent with `content`, can be replaced and deleted, and comes back from `q=source`. A summary on its own is still the content, as Post Type Discovery reads it. The MCP `create_note` and `update_note` tools take a `summary`
|
||||
- Article pages mark up the summary as `p-summary`; Atom entries have `<summary>` and JSON Feed items `summary`
|
||||
|
||||
### Changed
|
||||
|
||||
- A `# Heading` at the top of a note is now just a heading, not a title. Micropub `name` is stored as the title instead of being added to the text; a heading that repeats it is dropped
|
||||
- Feed items have a title only for articles. RSS items and JSON Feed items for notes have none, and Atom entries an empty one, so feed readers no longer show notes as headlines
|
||||
- On the homepage and tag pages an article shows its title, its summary (or the start of its text) and "Read more", without its images
|
||||
- Micropub content sent as both `html` and `text` is stored as the HTML. The text is usually a plain fallback, so articles lost their images, links and headings
|
||||
- Images embedded in Micropub content from other sites are copied into the media library and the text points at the copies, so an article doesn't break when the client's or a CDN's host goes away. Best effort: an image that can't be fetched keeps its URL (up to 20 per post)
|
||||
- Articles are crossposted to GoToSocial, Bluesky and Threads as title, summary (or the start of the text), link and hashtags, without images. On Bluesky the link card is the article. Notes are crossposted in full as before
|
||||
|
||||
### Fixed
|
||||
|
||||
- Feeds showed an article's title twice: as the item title and again at the top of the content
|
||||
- A line starting with a hashtag (`#indieweb is fun`) was shown as a heading on pages and in feeds, and crossposted without its `#`. Only `#` followed by a space starts a heading now, as in CommonMark
|
||||
- HTML content from Micropub is sanitized as is instead of going through Markdown, which added stray line breaks and empty paragraphs
|
||||
- Previews, image alt text and crosspost teasers showed raw Markdown (`**bold**`, `[link](url)`); the excerpt is now plain text
|
||||
## [2.15.0] - 2026-11-11
|
||||
|
||||
MCP server for AI clients (ADR-075).
|
||||
|
||||
@@ -139,8 +139,8 @@ again with the new content. `_fail()` does the same.
|
||||
a Threads container in `ERROR`/`EXPIRED`, and Graph API auth/permission
|
||||
errors (codes 10, 190, 200).
|
||||
- Other errors retry after `min(30 s × 2^attempts, 6 h)`. After 8 attempts
|
||||
the row becomes `failed`. The error is shown on the edit page with a
|
||||
Retry button. When a row finally fails, the owner also gets a `problems`
|
||||
the row becomes `failed`. The error is shown on the edit page and on the
|
||||
admin Log page (v2.18.0), both with a Retry button. When a row finally fails, the owner also gets a `problems`
|
||||
notification (ADR-074).
|
||||
- `RemoteGone` (404, or Graph error 100/33) during an update means the copy
|
||||
was deleted remotely, so a new one is created. During a delete it counts as
|
||||
@@ -273,7 +273,7 @@ reposts) that are due, each under a lease (`backfeed_claimed_until`):
|
||||
(`site_state.backfeed_backfill_last`). Start and finish times are in
|
||||
`site_state`.
|
||||
- **Refused credentials.** A 401/403 (or Graph auth error) puts the target
|
||||
in `backfeed.denied` until restart; the admin Webmentions page says which
|
||||
in `backfeed.denied` until restart; the admin Log page says which
|
||||
scopes are needed, and a `problems` notification is sent. Crossposting
|
||||
is unaffected.
|
||||
|
||||
|
||||
@@ -6,6 +6,8 @@ Accepted
|
||||
|
||||
> Its deferral of WebSub is superseded by ADR-071 (v2.10.0), and "no feed caching" by the feed cache added in v1.1.2. RSS is now one of three feed formats (ADR-038) and is served at `/feed.rss` (`/feed.xml` still works). (status updated 2026-11-03)
|
||||
|
||||
> Item titles: since v2.16.0 only articles (notes with a title) have one; notes have none, and no first-line or date title is made up (ADR-076).
|
||||
|
||||
## Context
|
||||
|
||||
Phase 5 requires implementing RSS feed generation for syndicating published notes. We need to decide on the implementation approach, feed format, caching strategy, and technical details for generating a standards-compliant RSS feed.
|
||||
|
||||
@@ -3,6 +3,8 @@
|
||||
## Status
|
||||
Accepted (implemented in v1.3.0, reviewed in v2.8.0; was: Proposed)
|
||||
|
||||
> Since v2.16.0 `p-name` is the stored title and `p-summary` the author's summary or, in previews, the start of the text (ADR-076).
|
||||
|
||||
## Context
|
||||
StarPunk currently implements basic microformats2 markup:
|
||||
- h-entry on note articles
|
||||
|
||||
@@ -1,7 +1,7 @@
|
||||
# ADR-062: Timestamp-Based Slug Format
|
||||
|
||||
## Status
|
||||
Accepted (Supersedes ADR-007)
|
||||
Accepted (Supersedes ADR-007). Articles take their slug from the title since v2.17.0 ([ADR-077](ADR-077-article-urls-and-title-slugs.md)).
|
||||
|
||||
## Context
|
||||
|
||||
|
||||
@@ -0,0 +1,74 @@
|
||||
# ADR-076: Article titles and summaries stored apart from the text
|
||||
|
||||
## Status
|
||||
|
||||
Accepted (v2.16.0, 2026-11-11)
|
||||
|
||||
Article URLs (`/article/<slug>`) and title slugs: [ADR-077](ADR-077-article-urls-and-title-slugs.md) (v2.17.0).
|
||||
|
||||
Supersedes the v2.3.3 design ([micropub-title-and-source-url](../design/v2.3.3/2026-10-31-micropub-title-and-source-url.md))
|
||||
and Q22's "a note has a title when its content starts with `#`". Amends
|
||||
ADR-014 (feed item titles) and ADR-040 (`p-name` and `p-summary`).
|
||||
|
||||
## Context
|
||||
|
||||
An IndieWeb article is an h-entry with a `name` that isn't just the start of
|
||||
its content (W3C Post Type Discovery). Since v1.2.0, StarPunk marked an article
|
||||
by a `# Heading` first line in the Markdown, and v2.3.3 stored a Micropub `name`
|
||||
as that heading. A review against IndieWeb practice found four gaps:
|
||||
|
||||
1. Feeds repeated an article's title: the item title, then the same heading
|
||||
rendered at the top of the content.
|
||||
2. Every feed item had a title, made from a note's first line (or the date),
|
||||
so feed readers showed notes as headlines and couldn't tell them from
|
||||
articles.
|
||||
3. Micropub `summary` was used only when `content` was missing; sent
|
||||
together with content, it was dropped.
|
||||
4. Any note that happened to start with a heading became an article, and its
|
||||
`q=source` changed from what the client sent. Micropub and mf2 treat `name`
|
||||
and `content` as separate properties.
|
||||
|
||||
## Decision
|
||||
|
||||
- **Columns.** `notes.title` and `notes.summary` (migration 023). A note with
|
||||
a title is an article; its Markdown file holds only the body. A heading in
|
||||
the body is just a heading.
|
||||
- **Moving existing titles.** Migration 023 has a Python data step
|
||||
(`migrations.DATA_MIGRATIONS`) that runs once, in the migration's
|
||||
transaction: for each note whose file starts with a heading (`split_title`,
|
||||
trashed files included), it moves the heading into `title`, rewrites the file
|
||||
and updates `content_hash`, then empties `notes_fts` so startup rebuilds it.
|
||||
If anything fails, the changed files are written back and the transaction is
|
||||
rolled back, so 023 is retried on the next start. Tying it to the migration
|
||||
matters: run on every start it would turn new notes' headings into titles.
|
||||
- **Micropub.** `name` → `title`; `summary` → `summary` when `content` is also
|
||||
sent. A summary on its own is still stored as the content, which is how Post
|
||||
Type Discovery reads it. `summary` can be replaced and deleted; `q=source`
|
||||
returns `name` and `summary` when set. If the content starts with a heading
|
||||
equal to `name`, that heading is dropped so it isn't shown twice.
|
||||
- **Feeds.** Only articles have a title: RSS leaves `<title>` out (an item
|
||||
needs a title or a description, and every item has a description), JSON Feed
|
||||
leaves `title` out, and Atom, which requires `<title>`, has an empty one.
|
||||
Atom `<summary>` and JSON Feed `summary` carry the author's summary. Content
|
||||
no longer contains the title, so it isn't repeated.
|
||||
- **Pages.** The article page has `p-name`, `p-summary` (when set) and the body
|
||||
as `e-content`. On the homepage and tag pages an article shows its title,
|
||||
summary (or the start of its text) and "Read more", without images. The
|
||||
photos stay in the markup as hidden `u-photo` values so parsers read the same
|
||||
post type there as on the article page.
|
||||
- **Crossposting.** Articles go to GoToSocial, Bluesky and Threads as title,
|
||||
summary (or the start of the text), link and hashtags, without images, the
|
||||
usual POSSE form for articles. On Bluesky the link card is the article
|
||||
itself. Notes are posted in full as before.
|
||||
- **Editor.** Title and Summary fields; a titled note may have no body.
|
||||
|
||||
## Consequences
|
||||
|
||||
- The migration rewrites note files. Back up the database *and* `data/notes`
|
||||
(and `.trash`) before deploying.
|
||||
- `Note.title` is `None` for notes. Places that need a name for any post use
|
||||
`Note.label` (title, else excerpt, else slug): notifications and the
|
||||
Bluesky card. `Note.has_title` and `Note.body_html` are gone.
|
||||
- Search indexes the title column; untitled notes are still listed by their
|
||||
first line.
|
||||
- A crossposted article that is edited is re-posted as a teaser.
|
||||
@@ -0,0 +1,46 @@
|
||||
# ADR-077: Article URLs and slugs from titles
|
||||
|
||||
## Status
|
||||
|
||||
Accepted (v2.17.0, 2026-11-12)
|
||||
|
||||
Amends ADR-062 (default slugs) for articles and ADR-076 (articles).
|
||||
|
||||
## Context
|
||||
|
||||
ADR-076 (v2.16.0) made a note with a title an article, but articles still got
|
||||
a `/note/<timestamp>` URL like any other note. An article is not a note, and
|
||||
its URL should say so. ADR-062 chose timestamp slugs because short notes have
|
||||
no good words for a URL and their text may be private; an article has a title
|
||||
written to be read, and that is the usual source of its slug on the IndieWeb.
|
||||
|
||||
## Decision
|
||||
|
||||
- **URLs.** Articles live at `/article/<slug>`, other notes at `/note/<slug>`.
|
||||
`Note.permalink`, `Note.url`, `Note.endpoint` and `utils.post_path` /
|
||||
`post_url` build them; nothing else writes `/note/` by hand. Slugs stay
|
||||
unique across both, so a slug still names one post.
|
||||
- **One URL each, the other redirects.** `/note/<slug>` for an article and
|
||||
`/article/<slug>` for a note answer 301 to the right one. Adding or removing
|
||||
a title changes the URL, and links made before (webmentions sent, crossposts,
|
||||
bookmarks) keep working. A deleted post is 410 at either.
|
||||
- **Slug from the title.** When a post is created with a title and no
|
||||
`mp-slug`, the slug is the title made URL-safe (`sanitize_slug`: accents
|
||||
folded, lowercase, hyphens), cut at a word boundary to 80 characters, `-2`,
|
||||
`-3`… if taken, `-article` if reserved. A title with nothing usable (only
|
||||
emoji, say) falls back to the timestamp slug. Notes keep timestamp slugs.
|
||||
- **Slugs don't follow later title changes.** Editing an article's title, or
|
||||
making a note an article, keeps its slug: a slug is the stable part of the
|
||||
URL.
|
||||
- **Micropub.** `Location` and `q=source` give the new URLs. Updates accept
|
||||
either URL. An update that adds or removes a title answers 201 with the new
|
||||
URL in `Location`, as the Micropub spec requires when a post's URL changes;
|
||||
other updates are still 204.
|
||||
- **Incoming webmentions** to either URL find the post.
|
||||
|
||||
## Consequences
|
||||
|
||||
- Production had no articles when this shipped, so no published URL changed.
|
||||
- A note given a title later keeps its timestamp slug under `/article/`.
|
||||
- Stored URLs (webmention sources, crosspost records) are not rewritten; the
|
||||
redirects cover them.
|
||||
+10
-8
@@ -5,8 +5,8 @@ records one decision: its context, what was decided, and the consequences.
|
||||
Superseded ADRs are kept as history; their Status line names the ADR that
|
||||
replaced them.
|
||||
|
||||
**Total ADR files**: 71 (70 numbers: ADR-001 to ADR-044 and ADR-050 to
|
||||
ADR-075, with two files numbered ADR-012). See [Numbering](#numbering).
|
||||
**Total ADR files**: 73 (72 numbers: ADR-001 to ADR-044 and ADR-050 to
|
||||
ADR-077, with two files numbered ADR-012). See [Numbering](#numbering).
|
||||
|
||||
Status values: **Accepted** (in force), **Superseded** (replaced by a later
|
||||
ADR), **Deprecated** (withdrawn, nothing replaces it; none at present),
|
||||
@@ -48,7 +48,7 @@ See also [database architecture](../architecture/database.md).
|
||||
|
||||
| ADR | Title | Status | Summary |
|
||||
|---|---|---|---|
|
||||
| [062](ADR-062-timestamp-based-slug-format.md) | Timestamp-Based Slug Format | Accepted | Default slugs are `YYYYMMDDHHMMSS` timestamps (v1.5.0); replaces ADR-007. |
|
||||
| [062](ADR-062-timestamp-based-slug-format.md) | Timestamp-Based Slug Format | Accepted* | Default slugs are `YYYYMMDDHHMMSS` timestamps (v1.5.0); replaces ADR-007. Articles take theirs from the title (ADR-077). |
|
||||
| [035](ADR-035-custom-slugs.md) | Custom Slugs in Micropub | Accepted* | Honour `mp-slug`, sanitized, with reserved names protected (v1.1.0). |
|
||||
| [034](ADR-034-full-text-search.md) | Full-Text Search with SQLite FTS5 | Accepted | FTS5 search over note content (v1.1.0). |
|
||||
| [057](ADR-057-media-attachment-model.md) | Media Attachment Model | Accepted | Social-media-style image attachments: up to 4 per note, ordered, with captions. |
|
||||
@@ -58,7 +58,7 @@ See also [database architecture](../architecture/database.md).
|
||||
|
||||
| ADR | Title | Status | Summary |
|
||||
|---|---|---|---|
|
||||
| [014](ADR-014-rss-feed-implementation.md) | RSS Feed Implementation Strategy | Accepted* | RSS 2.0 feed; its WebSub deferral is superseded by ADR-071. |
|
||||
| [014](ADR-014-rss-feed-implementation.md) | RSS Feed Implementation Strategy | Accepted* | RSS 2.0 feed; its WebSub deferral is superseded by ADR-071, and item titles by ADR-076. |
|
||||
| [038](ADR-038-syndication-formats.md) | Multiple Syndication Format Support | Accepted | RSS, Atom and JSON Feed side by side (v1.1.2). |
|
||||
| [071](ADR-071-websub.md) | WebSub publishing with a built-in hub | Accepted | Built-in WebSub hub at `/websub` for StarPunk's own feeds (v2.10.0, amended v2.10.1). |
|
||||
| [059](ADR-059-full-feed-media-standardization.md) | Full Feed Media Standardization (Option 3) | Proposed | Full Media RSS, podcasts, video and thumbnails in feeds; not scheduled. |
|
||||
@@ -67,7 +67,9 @@ See also [database architecture](../architecture/database.md).
|
||||
|
||||
| ADR | Title | Status | Summary |
|
||||
|---|---|---|---|
|
||||
| [040](ADR-040-microformats2-compliance.md) | Strict Microformats2 Compliance | Accepted | Full h-entry, h-card and h-feed markup (v1.3.0, reviewed v2.8.0). |
|
||||
| [040](ADR-040-microformats2-compliance.md) | Strict Microformats2 Compliance | Accepted* | Full h-entry, h-card and h-feed markup (v1.3.0, reviewed v2.8.0); `p-name`/`p-summary` per ADR-076. |
|
||||
| [076](ADR-076-note-title-and-summary-columns.md) | Article titles and summaries stored apart from the text | Accepted | `notes.title`/`summary` columns; feeds title only articles; article previews and crossposts are title + summary (v2.16.0). |
|
||||
| [077](ADR-077-article-urls-and-title-slugs.md) | Article URLs and slugs from titles | Accepted | Articles at `/article/<slug>` with slugs from their titles; the other prefix redirects (v2.17.0). |
|
||||
| [061](ADR-061-author-discovery.md) | Author Profile Discovery from IndieAuth | Accepted | The author h-card is read from `ADMIN_ME` and cached. |
|
||||
| [063](ADR-063-webmention-implementation.md) | Webmention Implementation | Accepted | Async receiving (202) and sending via a background worker, SSRF guard, rate limits, moderation (v1.6.0, revised up to v2.10.1). *Reconstructed.* |
|
||||
| [028](ADR-028-micropub-implementation.md) | Micropub Implementation Strategy | Accepted* | `/micropub` endpoint for creating posts (v1.0.0-rc.1); tokens now per ADR-064. |
|
||||
@@ -170,7 +172,7 @@ was carried out and is not itself superseded.
|
||||
|
||||
## How to create a new ADR
|
||||
|
||||
1. Use the next number after the highest existing one (currently ADR-076).
|
||||
1. Use the next number after the highest existing one (currently ADR-077).
|
||||
2. Name it `ADR-NNN-brief-descriptive-title.md`.
|
||||
3. Follow the format of recent ADRs (e.g. ADR-070, ADR-071):
|
||||
|
||||
@@ -203,5 +205,5 @@ was carried out and is not itself superseded.
|
||||
|
||||
---
|
||||
|
||||
**Last Updated**: 2026-11-10
|
||||
**Total ADR files**: 70
|
||||
**Last Updated**: 2026-11-11
|
||||
**Total ADR files**: 72
|
||||
@@ -343,6 +343,8 @@ Priority order:
|
||||
3. First h-card found (fallback)
|
||||
|
||||
### p-name Only With Explicit Title
|
||||
> Superseded in v2.16.0 (ADR-076): the title is `notes.title`, not a `#` first line. p-name still appears only for titled notes.
|
||||
|
||||
**Per Q22**:
|
||||
- Detected by checking if content starts with `#`
|
||||
- Matches note model's title extraction logic
|
||||
|
||||
@@ -0,0 +1,42 @@
|
||||
# v2.16.0: Article titles and summaries
|
||||
|
||||
Implements ADR-076. Prompted by a review of how StarPunk handles IndieWeb
|
||||
articles: titles were repeated in feeds, every feed item had a made-up title,
|
||||
Micropub `summary` was dropped, and any note starting with a heading became an
|
||||
article.
|
||||
|
||||
## What changed
|
||||
|
||||
| Area | Change |
|
||||
|---|---|
|
||||
| Storage | Migration 023 adds `notes.title` and `notes.summary`; `create_note`/`update_note` take `title` and `summary` (`UNCHANGED` sentinel on update; `None`/"" clears) |
|
||||
| Migration data step | `migrations.DATA_MIGRATIONS["023_note_titles.sql"] = _move_note_titles`; `run_migrations(..., data_dir=)` gets `DATA_PATH` from `init_db`. Moves `# Heading` first lines (via `split_title`) into `title`, finds trashed files with `utils.find_trashed_file` (shared with `undelete_note`), updates `content_hash`, empties `notes_fts`. Files are restored if the migration fails |
|
||||
| Model | `Note.title`/`summary` fields; `Note.label` for places that need some name; `has_title`, `body_html` and the first-line `title` property removed |
|
||||
| Micropub | `name` → title, `summary` → summary (only with content), `summary` updatable, `q=source` returns both; a heading repeating `name` is dropped (`drop_title_heading`) |
|
||||
| Feeds | Titles only for articles (RSS none, JSON none, Atom empty); Atom/JSON summaries |
|
||||
| Templates | Article page: `p-name`, `p-summary`, `e-content` without the title. Previews: title, summary or excerpt, "Read more", no images (hidden `u-photo` data kept for Post Type Discovery) |
|
||||
| Crossposting | `compose_text` posts articles as title + `article_teaser` (summary, or 200 characters of plain text) + link + hashtags; no images for articles; Bluesky card is the article |
|
||||
| Editor | Title and Summary fields on new/edit; content not required when titled |
|
||||
| Search | FTS indexes `title`; untitled notes still use their first line |
|
||||
| MCP | `create_note`/`update_note` take `summary`; note summaries include it |
|
||||
|
||||
## Fixes found along the way
|
||||
|
||||
- **Hashtag lines.** Python-Markdown made `#indieweb is fun` an `<h1>`; CommonMark needs a space after `#`. `markdown_ext.HashtagLineExtension` escapes the first `#` of a line where `#`s run straight into text, after fenced code and raw HTML are set aside. It is used for pages and feeds (`MARKDOWN_EXTENSIONS`) and crosspost plain text (`syndication._note_soup`), so the hashtag also reaches Bluesky as a tag. Search's first-line label keeps hashtags too.
|
||||
- **Plain-text excerpt.** `Note.excerpt` only stripped `#` marks, so previews showed `**bold**` and `[link](url)`. It is now `syndication.plain_text` of the content, cut to 200 characters with `…`; `article_teaser` is the summary or this excerpt.
|
||||
|
||||
- **Inline images in Micropub articles.** (1) `extract_content` prefers `html` over `text` and marks it `content_format = 'html'`: clients send `text` as a plain fallback, so images, links and headings were lost. (2) `localize_inline_images` copies images from other sites (Markdown `![]()` or `<img>`) into the media library through the SSRF-checked fetcher used for `photo`, on create and on content replace, and rewrites their URLs; failures keep the original URL, at most 20 per post. Images stay inline (not `u-photo`), so the post remains an article. (3) `Note.html` sanitizes HTML content with nh3 directly instead of passing it through Markdown.
|
||||
|
||||
## Choices made with the owner
|
||||
|
||||
- Title column rather than an editor-only field, as the most standards-compliant option.
|
||||
- Atom entries for notes keep an empty `<title>` (required by RFC 4287).
|
||||
- Homepage and tag pages: articles show title and summary without images.
|
||||
- Crossposts: articles as title + summary + link, no images.
|
||||
|
||||
## Tests
|
||||
|
||||
- `tests/test_articles.py` (new): feeds per format, article page mf2, homepage and tag-page previews, admin create/edit/clear, title-only article.
|
||||
- `tests/test_migration_023.py` (new): titles moved (including trashed notes), hashtag first line untouched, hashes and FTS, runs once, files restored on failure, schema-only without `data_dir`.
|
||||
- Updated for the new behaviour: `test_feed.py`, `test_feeds_{atom,json,rss}.py`, `test_routes_feed.py`, `test_models.py`, `test_microformats.py`, `test_microformats_v280.py`, `test_micropub.py`, `test_micropub_v240.py` (plus new summary and empty-body tests), `test_syndication.py` and `test_syndication_bluesky.py` (article crossposts).
|
||||
- Locally: the 35 affected test files, 872+ tests, pass. CI runs the full suite on the tag.
|
||||
@@ -0,0 +1,29 @@
|
||||
# v2.17.0: Article URLs and title slugs
|
||||
|
||||
Implements ADR-077. Follow-up to v2.16.0 (ADR-076): articles had `/note/`
|
||||
URLs and timestamp slugs.
|
||||
|
||||
## What changed
|
||||
|
||||
| Area | Change |
|
||||
|---|---|
|
||||
| URL helpers | `utils.post_path(slug, title)` and `post_url(slug, title)`; `Note.permalink` uses them, `Note.endpoint` (`public.article`/`public.note`) and `Note.url` (absolute) are new |
|
||||
| Routes | `public.article` at `/article/<slug>`; `note` and `article` share `_permalink(slug, endpoint)`, which 301s to the other route when the post's type doesn't match. `_note_was_deleted` checks both URLs for hard-deleted posts |
|
||||
| Slugs | `slug_utils.generate_title_slug(title, existing)`; `create_note` uses it for titled posts without `custom_slug`, else the timestamp slug |
|
||||
| Micropub | `Location`, `q=source` url via `note.url`; `_note_from_url` accepts `/article/`; update answers 201 + `Location` when a title is added or removed |
|
||||
| Other URL builders | Templates (`note.url`), webmention sending (`post_url`/`note.url`), crosspost permalink, backfeed target, notification links, search results (`article_title` from `notes.title`), MCP tools |
|
||||
| Webmention receiving | `resolve_target_note` accepts `/note/` and `/article/` |
|
||||
|
||||
## Tests
|
||||
|
||||
`tests/test_articles.py::TestArticleUrls`: Micropub URL and slug, timestamp
|
||||
slugs for notes, redirects both ways, updates via the old URL, slug rules
|
||||
(accents, duplicates, reserved, `mp-slug`, emoji, long titles), 201 on
|
||||
adding/removing a title, 410 for a deleted article, webmention targets and
|
||||
homepage links, search result URLs.
|
||||
|
||||
## v2.17.1
|
||||
|
||||
`post_url` first used `url_for`, which fails outside a request (the
|
||||
crosspost and backfeed workers); CI caught it in `test_likes_reposts.py`
|
||||
before 2.17.0 was built. It now joins `SITE_URL` and `post_path`.
|
||||
@@ -1,5 +1,7 @@
|
||||
# v2.3.3: Micropub titles, q=source URL, single title display
|
||||
|
||||
> Superseded in v2.16.0 by ADR-076: titles are stored in `notes.title`, not as a `# Heading` in the content, and `split_title` is used only to move old headings and drop a heading that repeats `name`.
|
||||
|
||||
Found while building tuipub, a terminal Micropub client, against StarPunk.
|
||||
|
||||
## Problems
|
||||
|
||||
@@ -0,0 +1,6 @@
|
||||
-- Migration 023: Note titles and summaries (v2.16.0, ADR-076)
|
||||
-- An article's title moves out of its Markdown ('# Heading' first line) into
|
||||
-- notes.title; migrations.py moves existing headings right after this runs.
|
||||
-- notes.summary holds an author-written summary (Micropub 'summary').
|
||||
ALTER TABLE notes ADD COLUMN title TEXT;
|
||||
ALTER TABLE notes ADD COLUMN summary TEXT;
|
||||
@@ -468,5 +468,5 @@ def create_app(config=None):
|
||||
|
||||
# Package version (Semantic Versioning 2.0.0)
|
||||
# See docs/standards/versioning-strategy.md for details
|
||||
__version__ = "2.15.0"
|
||||
__version_info__ = (2, 15, 0)
|
||||
__version__ = "2.18.0"
|
||||
__version_info__ = (2, 18, 0)
|
||||
@@ -25,6 +25,7 @@ from typing import Dict, List, Optional
|
||||
from flask import current_app
|
||||
|
||||
from starpunk.database import get_db
|
||||
from starpunk.utils import post_path
|
||||
|
||||
DAY = 24 * 3600
|
||||
SCHEDULE = [ # (note younger than, check every), in seconds
|
||||
@@ -164,7 +165,7 @@ def _due(db, limit: int) -> list:
|
||||
lease = "(s.backfeed_claimed_until IS NULL OR s.backfeed_claimed_until < datetime('now'))"
|
||||
rows = db.execute(
|
||||
f"""
|
||||
SELECT s.*, n.created_at AS note_created, n.slug AS note_slug {_ELIGIBLE}
|
||||
SELECT s.*, n.created_at AS note_created, n.slug AS note_slug, n.title AS note_title {_ELIGIBLE}
|
||||
AND {lease}
|
||||
AND n.created_at >= datetime('now', ?)
|
||||
AND (s.backfeed_next_at IS NULL OR s.backfeed_next_at <= datetime('now'))
|
||||
@@ -176,7 +177,7 @@ def _due(db, limit: int) -> list:
|
||||
return rows
|
||||
backfill = db.execute(
|
||||
f"""
|
||||
SELECT s.*, n.created_at AS note_created, n.slug AS note_slug {_ELIGIBLE}
|
||||
SELECT s.*, n.created_at AS note_created, n.slug AS note_slug, n.title AS note_title {_ELIGIBLE}
|
||||
AND {lease} AND s.backfeed_backfill = 1
|
||||
AND (s.backfeed_next_at IS NULL OR s.backfeed_next_at <= datetime('now'))
|
||||
ORDER BY s.id LIMIT 1
|
||||
@@ -381,7 +382,7 @@ def check(row, target) -> None:
|
||||
# older note (e.g. one linked after the fact). ADR-074 Decision 5.
|
||||
quiet = bool(row["backfeed_backfill"]) or (
|
||||
row["backfeed_checked_at"] is None and _age_seconds(row["note_created"]) > DAY)
|
||||
store(db, row["note_id"], f"{site}/note/{row['note_slug']}", row["target"], harvest, quiet=quiet)
|
||||
store(db, row["note_id"], site + post_path(row["note_slug"], row["note_title"]), row["target"], harvest, quiet=quiet)
|
||||
_store_counts(db, row["id"], hidden_counts(harvest))
|
||||
|
||||
|
||||
|
||||
@@ -17,10 +17,12 @@ def init_db(app=None):
|
||||
if app:
|
||||
db_path = app.config["DATABASE_PATH"]
|
||||
logger = app.logger
|
||||
data_dir = app.config.get("DATA_PATH")
|
||||
else:
|
||||
# Fallback to default path
|
||||
db_path = Path("./data/starpunk.db")
|
||||
logger = None
|
||||
data_dir = None
|
||||
|
||||
# Ensure parent directory exists
|
||||
db_path.parent.mkdir(parents=True, exist_ok=True)
|
||||
@@ -41,4 +43,4 @@ def init_db(app=None):
|
||||
|
||||
# Run migrations
|
||||
from starpunk.migrations import run_migrations
|
||||
run_migrations(db_path, logger=logger)
|
||||
run_migrations(db_path, logger=logger, data_dir=data_dir)
|
||||
@@ -0,0 +1,127 @@
|
||||
"""
|
||||
Error log for the admin Log page (v2.18.0)
|
||||
|
||||
Collects what is failing right now from the tables that already record it:
|
||||
crossposts, response checks (backfeed), outgoing webmentions, reply-context
|
||||
fetches, WebSub deliveries and notifications. Nothing new is stored. An entry
|
||||
disappears once the next attempt succeeds, so the page lists only problems
|
||||
that still need attention.
|
||||
|
||||
Each entry is a dict:
|
||||
when -- timestamp text (UTC) or "" when unknown
|
||||
area -- short label, e.g. "Crosspost to Bluesky"
|
||||
note -- the affected Note, or None for site-wide problems
|
||||
detail -- extra context (a URL or "retrying"), may be ""
|
||||
error -- the recorded error message
|
||||
action -- optional (endpoint, id, label) for a retry button
|
||||
"""
|
||||
|
||||
from flask import current_app
|
||||
|
||||
from starpunk.database import get_db
|
||||
|
||||
SILOS = {"gotosocial": "GoToSocial", "bluesky": "Bluesky", "threads": "Threads"}
|
||||
|
||||
|
||||
def _silo(target: str) -> str:
|
||||
return SILOS.get(target, target)
|
||||
|
||||
|
||||
def _notes(ids) -> dict:
|
||||
"""Load the affected notes once each (deleted notes come back as None)"""
|
||||
from starpunk.notes import get_note
|
||||
|
||||
return {i: get_note(id=i) for i in set(ids) if i is not None}
|
||||
|
||||
|
||||
def entries() -> list:
|
||||
"""Every current error, newest first; site-wide problems come first"""
|
||||
from starpunk import backfeed, notifications
|
||||
|
||||
db = get_db(current_app)
|
||||
rows = []
|
||||
|
||||
for r in db.execute(
|
||||
"SELECT id, note_id, target, state, last_error, updated_at FROM syndications "
|
||||
"WHERE last_error IS NOT NULL AND state != 'synced'"
|
||||
):
|
||||
rows.append({
|
||||
"when": r["updated_at"], "area": f"Crosspost to {_silo(r['target'])}",
|
||||
"note_id": r["note_id"], "detail": "retrying" if r["state"] == "pending" else "",
|
||||
"error": r["last_error"],
|
||||
"action": ("admin.retry_syndication", r["id"], "Retry"),
|
||||
})
|
||||
|
||||
for r in db.execute(
|
||||
"SELECT id, note_id, target, backfeed_error, backfeed_checked_at, remote_url FROM syndications "
|
||||
"WHERE backfeed_error IS NOT NULL"
|
||||
):
|
||||
rows.append({
|
||||
"when": r["backfeed_checked_at"], "area": f"Response check on {_silo(r['target'])}",
|
||||
"note_id": r["note_id"], "detail": r["remote_url"] or "", "error": r["backfeed_error"],
|
||||
"action": ("admin.check_syndication_responses", r["id"], "Check now"),
|
||||
})
|
||||
|
||||
for r in db.execute(
|
||||
"SELECT source_note_id, target_url, status, last_error, COALESCE(started_at, created_at) AS at "
|
||||
"FROM webmention_queue WHERE last_error IS NOT NULL AND status IN ('pending', 'failed')"
|
||||
):
|
||||
rows.append({
|
||||
"when": r["at"], "area": "Webmention sent", "note_id": r["source_note_id"],
|
||||
"detail": r["target_url"] + (" (retrying)" if r["status"] == "pending" else ""),
|
||||
"error": r["last_error"], "action": None,
|
||||
})
|
||||
|
||||
for r in db.execute(
|
||||
"SELECT n.id AS note_id, rc.url, rc.fetch_error, rc.fetched_at, rc.created_at "
|
||||
"FROM reply_contexts rc JOIN notes n ON n.in_reply_to = rc.url "
|
||||
"WHERE rc.fetch_status = 'error' AND n.deleted_at IS NULL"
|
||||
):
|
||||
rows.append({
|
||||
"when": r["fetched_at"] or r["created_at"], "area": "Reply context fetch",
|
||||
"note_id": r["note_id"], "detail": r["url"], "error": r["fetch_error"] or "fetch failed",
|
||||
"action": None,
|
||||
})
|
||||
|
||||
for r in db.execute(
|
||||
"SELECT topic, callback, last_error, COALESCE(last_success_at, verified_at, created_at) AS at "
|
||||
"FROM websub_subscriptions WHERE last_error IS NOT NULL"
|
||||
):
|
||||
rows.append({
|
||||
"when": r["at"], "area": "WebSub delivery", "note_id": None,
|
||||
"detail": f"{r['topic']} → {r['callback']}", "error": r["last_error"], "action": None,
|
||||
})
|
||||
|
||||
rows.sort(key=lambda e: str(e["when"] or ""), reverse=True)
|
||||
|
||||
site = []
|
||||
for silo, message in backfeed.denied.items():
|
||||
site.append({"when": "", "area": f"Response checks on {_silo(silo)}", "note_id": None,
|
||||
"detail": "paused", "error": message, "action": None})
|
||||
notify_error = notifications.last_error(db)
|
||||
if notify_error:
|
||||
when, _, message = notify_error.partition(" UTC ")
|
||||
site.append({"when": when if message else "", "area": "Notifications", "note_id": None,
|
||||
"detail": "", "error": message or notify_error, "action": None})
|
||||
|
||||
entries = site + rows
|
||||
notes = _notes(e["note_id"] for e in entries)
|
||||
for e in entries:
|
||||
e["note"] = notes.get(e.pop("note_id"))
|
||||
return entries
|
||||
|
||||
|
||||
def count() -> int:
|
||||
"""Cheap total for the admin nav badge"""
|
||||
from starpunk import backfeed, notifications
|
||||
|
||||
db = get_db(current_app)
|
||||
total = db.execute(
|
||||
"SELECT (SELECT COUNT(*) FROM syndications WHERE last_error IS NOT NULL AND state != 'synced')"
|
||||
" + (SELECT COUNT(*) FROM syndications WHERE backfeed_error IS NOT NULL)"
|
||||
" + (SELECT COUNT(*) FROM webmention_queue WHERE last_error IS NOT NULL AND status IN ('pending', 'failed'))"
|
||||
" + (SELECT COUNT(*) FROM reply_contexts rc JOIN notes n ON n.in_reply_to = rc.url"
|
||||
" WHERE rc.fetch_status = 'error' AND n.deleted_at IS NULL)"
|
||||
" + (SELECT COUNT(*) FROM websub_subscriptions WHERE last_error IS NOT NULL)"
|
||||
).fetchone()[0]
|
||||
return total + len(backfeed.denied) + (1 if notifications.last_error(db) else 0)
|
||||
@@ -161,7 +161,10 @@ def generate_atom_streaming(
|
||||
|
||||
# Required elements
|
||||
yield f' <id>{_escape_xml(permalink)}</id>\n'
|
||||
yield f' <title>{_escape_xml(note.title)}</title>\n'
|
||||
# atom:title is required but may be empty: untitled notes (ADR-076)
|
||||
yield f' <title>{_escape_xml(note.title or "")}</title>\n'
|
||||
if note.summary:
|
||||
yield f' <summary>{_escape_xml(note.summary)}</summary>\n'
|
||||
|
||||
# Use created_at for both published and updated
|
||||
# (Note model doesn't have updated_at tracking yet)
|
||||
|
||||
@@ -229,8 +229,12 @@ def _build_item_object(site_url: str, note: Note) -> Dict[str, Any]:
|
||||
"url": permalink,
|
||||
}
|
||||
|
||||
# Add title
|
||||
item["title"] = note.title
|
||||
# Title and summary only when the note has them: untitled notes have
|
||||
# no title (JSON Feed 1.1; v2.16.0, ADR-076)
|
||||
if note.title:
|
||||
item["title"] = note.title
|
||||
if note.summary:
|
||||
item["summary"] = note.summary
|
||||
|
||||
# Add image field (URL of first/main image) - per JSON Feed 1.1 spec
|
||||
# Per Q7: Field should be absent (not null) when no media
|
||||
|
||||
+14
-37
@@ -108,7 +108,9 @@ def generate_rss(
|
||||
|
||||
# Set required item elements
|
||||
fe.id(permalink)
|
||||
fe.title(get_note_title(note))
|
||||
title = get_note_title(note)
|
||||
if title: # untitled notes have only a description (RSS 2.0, ADR-076)
|
||||
fe.title(title)
|
||||
fe.link(href=permalink)
|
||||
fe.guid(permalink, permalink=True)
|
||||
|
||||
@@ -263,8 +265,8 @@ def generate_rss_streaming(
|
||||
html_content += clean_html_for_rss(note.feed_html)
|
||||
|
||||
# Build item XML
|
||||
item_xml = f""" <item>
|
||||
<title>{_escape_xml(title)}</title>
|
||||
title_xml = f"\n <title>{_escape_xml(title)}</title>" if title else ""
|
||||
item_xml = f""" <item>{title_xml}
|
||||
<link>{_escape_xml(permalink)}</link>
|
||||
<guid isPermaLink="true">{_escape_xml(permalink)}</guid>
|
||||
<pubDate>{pub_date_str}</pubDate>"""
|
||||
@@ -494,48 +496,23 @@ def format_rfc822_date(dt: datetime) -> str:
|
||||
return dt.strftime("%a, %d %b %Y %H:%M:%S %z")
|
||||
|
||||
|
||||
def get_note_title(note: Note) -> str:
|
||||
def get_note_title(note: Note) -> Optional[str]:
|
||||
"""
|
||||
Extract title from note content
|
||||
An item's title: the note's title (articles), cut to 100 characters
|
||||
|
||||
Attempts to extract a meaningful title from the note. Uses the first
|
||||
line of content (stripped of markdown heading syntax) or falls back
|
||||
to a formatted timestamp if content is unavailable.
|
||||
|
||||
Algorithm:
|
||||
1. Try note.title property (first line, stripped of # syntax)
|
||||
2. Fall back to timestamp if title is unavailable
|
||||
Untitled notes get none (v2.16.0, ADR-076), so readers can tell notes
|
||||
from articles; RSS 2.0 lets an item have just a description.
|
||||
|
||||
Args:
|
||||
note: Note object
|
||||
|
||||
Returns:
|
||||
Title string (max 100 chars, truncated if needed)
|
||||
|
||||
Examples:
|
||||
>>> # Note with heading
|
||||
>>> note = Note(...) # content: "# My First Note\\n\\n..."
|
||||
>>> get_note_title(note)
|
||||
'My First Note'
|
||||
|
||||
>>> # Note without heading (timestamp fallback)
|
||||
>>> note = Note(...) # content: "Just some text"
|
||||
>>> get_note_title(note)
|
||||
'November 18, 2024 at 12:00 PM'
|
||||
Title string, or None for an untitled note
|
||||
"""
|
||||
try:
|
||||
# Use Note's title property (handles extraction logic)
|
||||
title = note.title
|
||||
|
||||
# Truncate to 100 characters for RSS compatibility
|
||||
if len(title) > 100:
|
||||
title = title[:100].strip() + "..."
|
||||
|
||||
return title
|
||||
|
||||
except (FileNotFoundError, OSError, AttributeError):
|
||||
# If title extraction fails, use timestamp
|
||||
return note.created_at.strftime("%B %d, %Y at %I:%M %p")
|
||||
title = note.title
|
||||
if title and len(title) > 100:
|
||||
title = title[:100].strip() + "..."
|
||||
return title or None
|
||||
|
||||
|
||||
def clean_html_for_rss(html: str) -> str:
|
||||
|
||||
@@ -1,7 +1,12 @@
|
||||
"""
|
||||
Markdown extension: turn bare URLs into links (v2.3.0)
|
||||
Markdown extensions for notes
|
||||
|
||||
Python-Markdown only links <https://...>; notes often contain pasted URLs.
|
||||
BareUrlExtension: turn bare URLs into links (v2.3.0). Python-Markdown only
|
||||
links <https://...>; notes often contain pasted URLs.
|
||||
|
||||
HashtagLineExtension: a line starting with a hashtag stays text (v2.16.0).
|
||||
Python-Markdown makes '#indieweb is fun' a heading; CommonMark (and every
|
||||
other Markdown a client may use) needs a space after the '#'.
|
||||
"""
|
||||
|
||||
import re
|
||||
@@ -9,6 +14,7 @@ import xml.etree.ElementTree as etree
|
||||
|
||||
from markdown.extensions import Extension
|
||||
from markdown.inlinepatterns import InlineProcessor
|
||||
from markdown.preprocessors import Preprocessor
|
||||
from markdown.treeprocessors import Treeprocessor
|
||||
from markdown.util import AtomicString
|
||||
|
||||
@@ -40,3 +46,20 @@ class BareUrlExtension(Extension):
|
||||
# Below links (160) and <autolinks> (120), so those win
|
||||
md.inlinePatterns.register(_BareUrl(BARE_URL_RE, md), "bare_url", 105)
|
||||
md.treeprocessors.register(_UnnestLinks(md), "unnest_links", 0)
|
||||
|
||||
|
||||
# Up to 3 spaces, then '#'s straight followed by text: a hashtag, not a heading
|
||||
_HASHTAG_LINE_RE = re.compile(r"^( {0,3})(?=#+[^\s#])")
|
||||
|
||||
|
||||
class _HashtagLines(Preprocessor):
|
||||
"""Escape the first '#' of such a line, so it renders as text"""
|
||||
|
||||
def run(self, lines):
|
||||
return [_HASHTAG_LINE_RE.sub(r"\1\\", line) for line in lines]
|
||||
|
||||
|
||||
class HashtagLineExtension(Extension):
|
||||
def extendMarkdown(self, md):
|
||||
# After fenced code (25) and raw HTML (20) are set aside, so code is untouched
|
||||
md.preprocessors.register(_HashtagLines(md), "hashtag_lines", 15)
|
||||
@@ -60,19 +60,20 @@ def _clamp(limit: int) -> int:
|
||||
return max(1, min(int(limit), MAX_LIMIT))
|
||||
|
||||
|
||||
def _note_url(slug: str) -> str:
|
||||
from starpunk.utils import absolute_url_for
|
||||
def _note_url(slug: str, title=None) -> str:
|
||||
from starpunk.utils import post_url
|
||||
|
||||
return absolute_url_for("public.note", slug=slug)
|
||||
return post_url(slug, title)
|
||||
|
||||
|
||||
def _summary(note) -> dict:
|
||||
from starpunk.utils import iso_utc
|
||||
|
||||
return {
|
||||
"url": _note_url(note.slug),
|
||||
"url": note.url,
|
||||
"slug": note.slug,
|
||||
"title": note.title,
|
||||
"summary": note.summary,
|
||||
"kind": note.kind,
|
||||
"status": "published" if note.published else "draft",
|
||||
"published": iso_utc(note.created_at),
|
||||
@@ -138,7 +139,7 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
results = fts(query=query, db_path=db_path, published_only=not include_drafts, limit=_clamp(limit))
|
||||
return {
|
||||
"results": [
|
||||
{"url": _note_url(r["slug"]), "slug": r["slug"], "title": r.get("title"),
|
||||
{"url": _note_url(r["slug"], r.get("article_title")), "slug": r["slug"], "title": r.get("title"),
|
||||
"snippet": r.get("snippet")}
|
||||
for r in results
|
||||
]
|
||||
@@ -175,7 +176,7 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
note = _find_note(url_or_slug)
|
||||
if not note.published and not _sees_drafts(info):
|
||||
raise ToolError("Note not found")
|
||||
return {"url": _note_url(note.slug), "slug": note.slug,
|
||||
return {"url": note.url, "slug": note.slug,
|
||||
"properties": note_to_mf2(note)["properties"]}
|
||||
|
||||
return await run(one)
|
||||
@@ -217,6 +218,7 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
async def create_note(
|
||||
content: str = "",
|
||||
title: Optional[str] = None,
|
||||
summary: Optional[str] = None,
|
||||
tags: Optional[list[str]] = None,
|
||||
draft: bool = True,
|
||||
photos: Optional[list[Photo]] = None,
|
||||
@@ -230,7 +232,8 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
) -> dict:
|
||||
"""Create a note (Markdown). It is a draft unless draft is false;
|
||||
publishing makes it public and crossposts it to the syndicate_to
|
||||
targets. A title makes it an article. At most one of like_of,
|
||||
targets. A title makes it an article; summary is its short summary,
|
||||
shown on the homepage and in feeds and crossposts. At most one of like_of,
|
||||
repost_of and bookmark_of. published_at is an ISO 8601 date."""
|
||||
info = _token_info()
|
||||
_require(info, "create", "draft")
|
||||
@@ -240,6 +243,8 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
props["content"] = [content]
|
||||
if title:
|
||||
props["name"] = [title]
|
||||
if summary:
|
||||
props["summary"] = [summary]
|
||||
if tags:
|
||||
props["category"] = list(tags)
|
||||
if photos:
|
||||
@@ -268,6 +273,7 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
url: str,
|
||||
content: Optional[str] = None,
|
||||
title: Optional[str] = None,
|
||||
summary: Optional[str] = None,
|
||||
tags: Optional[list[str]] = None,
|
||||
add_tags: Optional[list[str]] = None,
|
||||
remove_tags: Optional[list[str]] = None,
|
||||
@@ -276,7 +282,7 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
in_reply_to: Optional[str] = None,
|
||||
) -> dict:
|
||||
"""Change a note. Only the fields given change: content replaces the
|
||||
text, title replaces the title ("" removes it), tags replaces all
|
||||
text, title replaces the title ("" removes it), summary likewise, tags replaces all
|
||||
tags, add_tags/remove_tags adjust them, photos replaces all photos,
|
||||
draft false publishes a draft (and crossposts it) and true unpublishes.
|
||||
Edits to published notes follow to their crossposts."""
|
||||
@@ -288,6 +294,8 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
replace["content"] = [content]
|
||||
if title is not None:
|
||||
replace["name"] = [title]
|
||||
if summary is not None:
|
||||
replace["summary"] = [summary]
|
||||
if tags is not None:
|
||||
replace["category"] = list(tags)
|
||||
if draft is not None:
|
||||
@@ -306,7 +314,7 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
from starpunk.micropub import handle_update
|
||||
|
||||
note = _find_note(url)
|
||||
data["url"] = _note_url(note.slug)
|
||||
data["url"] = note.url
|
||||
handle_update(data, info)
|
||||
return _status_after(data["url"])
|
||||
|
||||
@@ -321,7 +329,7 @@ def register_tools(server: MCPServer, app: Flask) -> None:
|
||||
def delete():
|
||||
from starpunk.micropub import handle_delete
|
||||
|
||||
note_url = _note_url(_find_note(url).slug)
|
||||
note_url = _find_note(url).url
|
||||
handle_delete({"url": note_url}, info)
|
||||
return {"url": note_url, "status": "deleted"}
|
||||
|
||||
|
||||
+98
-40
@@ -7,7 +7,8 @@ interface for creating posts via external clients.
|
||||
Functions:
|
||||
normalize_properties: Convert form/JSON data to Micropub properties format
|
||||
extract_content: Get content from Micropub properties
|
||||
extract_title: Get the explicit title (name) from Micropub properties
|
||||
extract_title: Get the title (name) from Micropub properties
|
||||
extract_summary: Get the author's summary from Micropub properties
|
||||
extract_tags: Get category tags from Micropub properties
|
||||
handle_create: Process Micropub create action
|
||||
handle_update: Process Micropub update action (v2.4.0)
|
||||
@@ -204,10 +205,11 @@ def extract_content(properties: dict) -> str:
|
||||
|
||||
content = content_list[0]
|
||||
|
||||
# Handle structured content ({"html": "...", "text": "..."})
|
||||
# Handle structured content ({"html": "...", "text": "..."}). The HTML is
|
||||
# what was written; clients send text as a plain fallback, which loses
|
||||
# images, links and headings (v2.16.0; before, text was preferred)
|
||||
if isinstance(content, dict):
|
||||
# Prefer text over html for markdown storage
|
||||
content = content.get("text") or content.get("html", "")
|
||||
content = content.get("html") or content.get("text", "")
|
||||
|
||||
if not isinstance(content, str) or not content.strip():
|
||||
raise MicropubValidationError("Content cannot be empty")
|
||||
@@ -216,9 +218,9 @@ def extract_content(properties: dict) -> str:
|
||||
|
||||
|
||||
def content_format(properties: dict) -> Optional[str]:
|
||||
"""'html' if the content was sent only as HTML (returned as such by q=source)"""
|
||||
"""'html' if the content was sent as HTML (returned as such by q=source)"""
|
||||
content = _first(properties.get("content"))
|
||||
if isinstance(content, dict) and content.get("html") and not content.get("text"):
|
||||
if isinstance(content, dict) and content.get("html"):
|
||||
return "html"
|
||||
return None
|
||||
|
||||
@@ -235,10 +237,7 @@ def _has_text(content) -> bool:
|
||||
|
||||
def extract_title(properties: dict) -> Optional[str]:
|
||||
"""
|
||||
Extract the explicit title (Micropub 'name' property)
|
||||
|
||||
StarPunk has no title field: a note's title is a '# Heading' first line
|
||||
(see Note.title), so the caller stores the name as that heading.
|
||||
Extract the title (Micropub 'name' property), stored in notes.title (ADR-076)
|
||||
|
||||
Args:
|
||||
properties: Normalized Micropub properties dict
|
||||
@@ -252,14 +251,22 @@ def extract_title(properties: dict) -> Optional[str]:
|
||||
return " ".join(name.split()) or None
|
||||
|
||||
|
||||
def add_title_heading(content: str, title: Optional[str]) -> str:
|
||||
"""Prefix content with '# title' unless it already starts with that heading"""
|
||||
if not title:
|
||||
return content
|
||||
first_line = content.lstrip().split("\n", 1)[0]
|
||||
if first_line.startswith("#") and first_line.lstrip("#").strip() == title:
|
||||
return content
|
||||
return f"# {title}\n\n{content}"
|
||||
def extract_summary(properties: dict) -> Optional[str]:
|
||||
"""The author's summary (Micropub 'summary' property, v2.16.0), as plain text"""
|
||||
summary = _first(properties.get("summary"))
|
||||
if isinstance(summary, dict):
|
||||
summary = summary.get("text") or summary.get("value") or ""
|
||||
if not isinstance(summary, str):
|
||||
return None
|
||||
return summary.strip() or None
|
||||
|
||||
|
||||
def drop_title_heading(content: str, title: Optional[str]) -> str:
|
||||
"""Content without a '# heading' first line that only repeats the title"""
|
||||
heading, rest = split_title(content)
|
||||
if title and heading == title:
|
||||
return rest
|
||||
return content
|
||||
|
||||
|
||||
def extract_tags(properties: dict) -> list[str]:
|
||||
@@ -308,7 +315,7 @@ MAX_PHOTOS = 4 # ADR-057
|
||||
MAX_REMOTE_PHOTO_BYTES = 20 * 1024 * 1024
|
||||
|
||||
# Properties we can store, and so can be updated (v2.4.0)
|
||||
UPDATABLE = {"content", "name", "category", "in-reply-to", "post-status", "photo"}
|
||||
UPDATABLE = {"content", "name", "summary", "category", "in-reply-to", "post-status", "photo"}
|
||||
|
||||
|
||||
def _first(value):
|
||||
@@ -407,9 +414,10 @@ def _public_address(host: str) -> bool:
|
||||
return bool(infos)
|
||||
|
||||
|
||||
def _fetch_remote_photo(url: str) -> Optional[int]:
|
||||
def _fetch_remote_photo(url: str) -> Optional[dict]:
|
||||
"""
|
||||
Download a photo hosted elsewhere into the media library. Returns media id.
|
||||
Download a photo hosted elsewhere into the media library. Returns the
|
||||
saved media ({'id', 'path', ...}), or None if it couldn't be fetched.
|
||||
|
||||
Uses the webmention fetcher (v2.9.0): every redirect is checked against
|
||||
private addresses and the connection is pinned to the checked address.
|
||||
@@ -426,7 +434,7 @@ def _fetch_remote_photo(url: str) -> Optional[int]:
|
||||
if result.status_code != 200:
|
||||
raise ValueError(f"HTTP {result.status_code}")
|
||||
name = urlparse(result.url).path.rsplit("/", 1)[-1] or "photo.jpg"
|
||||
return save_media(result.content, name)["id"]
|
||||
return save_media(result.content, name)
|
||||
except Exception as e:
|
||||
current_app.logger.warning(f"Could not fetch photo {url}: {e}")
|
||||
return None
|
||||
@@ -446,7 +454,35 @@ def _media_id_for_url(url: str) -> Optional[int]:
|
||||
return row[0]
|
||||
current_app.logger.warning(f"Photo URL not found in media: {url}")
|
||||
return None
|
||||
return _fetch_remote_photo(url)
|
||||
media = _fetch_remote_photo(url)
|
||||
return media["id"] if media else None
|
||||
|
||||
|
||||
MAX_INLINE_IMAGES = 20
|
||||
|
||||
|
||||
def localize_inline_images(content: str) -> str:
|
||||
"""
|
||||
Copy images embedded in the text from other sites into the media library
|
||||
and point the text at the copies (v2.16.0), so an article doesn't depend
|
||||
on the client's or a CDN's host staying up. Best effort: an image that
|
||||
can't be fetched keeps its URL.
|
||||
"""
|
||||
from html import escape
|
||||
from starpunk.syndication import inline_images
|
||||
|
||||
if not content or "<img" not in content and "![" not in content:
|
||||
return content
|
||||
site_url = current_app.config.get("SITE_URL", "").rstrip("/")
|
||||
remote = [url for url, _ in inline_images(content)
|
||||
if url.startswith(("http://", "https://")) and not url.startswith(site_url + "/")]
|
||||
for url in list(dict.fromkeys(remote))[:MAX_INLINE_IMAGES]:
|
||||
media = _fetch_remote_photo(url)
|
||||
if media:
|
||||
local = f"{site_url}/media/{media['path']}"
|
||||
# As written in Markdown, and as it may be escaped in HTML attributes
|
||||
content = content.replace(url, local).replace(escape(url), local)
|
||||
return content
|
||||
|
||||
|
||||
def _save_uploads(files) -> list[dict]:
|
||||
@@ -513,7 +549,7 @@ def _check_type(data: dict) -> None:
|
||||
|
||||
|
||||
def _note_from_url(url: Optional[str], deleted: bool = False):
|
||||
"""Find the note a URL points at (/note/<slug> on this site)"""
|
||||
"""Find the note a URL points at (/note/<slug> or /article/<slug> on this site)"""
|
||||
from urllib.parse import urlparse
|
||||
from starpunk.database import get_db
|
||||
|
||||
@@ -524,7 +560,7 @@ def _note_from_url(url: Optional[str], deleted: bool = False):
|
||||
if parsed.netloc and site.netloc and parsed.netloc != site.netloc:
|
||||
raise MicropubValidationError("URL is not on this site")
|
||||
parts = [p for p in parsed.path.split("/") if p]
|
||||
if len(parts) != 2 or parts[0] not in ("note", "notes"):
|
||||
if len(parts) != 2 or parts[0] not in ("note", "notes", "article", "articles"):
|
||||
raise MicropubValidationError("URL is not a post on this site")
|
||||
slug = parts[1]
|
||||
if deleted:
|
||||
@@ -596,6 +632,10 @@ def handle_create(data: dict, token_info: dict, files=None):
|
||||
if has_content or not (like_of or repost_of or bookmark_of or photos or title)
|
||||
else ""
|
||||
)
|
||||
content = localize_inline_images(drop_title_heading(content, title))
|
||||
# A summary with content is the author's summary; alone it is the
|
||||
# content (Post Type Discovery), as extract_content does (v2.16.0)
|
||||
summary = extract_summary(properties) if _has_text(properties.get("content")) else None
|
||||
tags = extract_tags(properties)
|
||||
published_date = extract_published_date(properties)
|
||||
published = extract_post_status(properties) and not extract_visibility_draft(properties)
|
||||
@@ -615,7 +655,9 @@ def handle_create(data: dict, token_info: dict, files=None):
|
||||
note = None
|
||||
try:
|
||||
note = create_note(
|
||||
content=add_title_heading(content, title),
|
||||
content=content,
|
||||
title=title,
|
||||
summary=summary,
|
||||
published=published,
|
||||
created_at=published_date,
|
||||
custom_slug=custom_slug,
|
||||
@@ -636,7 +678,7 @@ def handle_create(data: dict, token_info: dict, files=None):
|
||||
from starpunk.syndication import resolve_targets, select_targets
|
||||
select_targets(note.id, resolve_targets(requested_targets))
|
||||
|
||||
return "", 201, {"Location": absolute_url_for("public.note", slug=note.slug)}
|
||||
return "", 201, {"Location": note.url}
|
||||
|
||||
except InvalidNoteDataError as e:
|
||||
raise MicropubValidationError(str(e))
|
||||
@@ -686,7 +728,7 @@ def handle_update(data: dict, token_info: dict):
|
||||
|
||||
from starpunk.tags import get_note_tags
|
||||
|
||||
title, body = split_title(note.content)
|
||||
title, summary, body = note.title, note.summary, note.content
|
||||
tags = [t["display_name"] for t in get_note_tags(note.id, entered_order=True)]
|
||||
photos = _note_photos(note)
|
||||
changes = {}
|
||||
@@ -696,6 +738,8 @@ def handle_update(data: dict, token_info: dict):
|
||||
for prop in delete:
|
||||
if prop == "name":
|
||||
title = None
|
||||
elif prop == "summary":
|
||||
summary = None
|
||||
elif prop == "content":
|
||||
body = ""
|
||||
elif prop == "category":
|
||||
@@ -719,10 +763,12 @@ def handle_update(data: dict, token_info: dict):
|
||||
|
||||
if "content" in replace:
|
||||
# Empty text is fine if the note keeps its photos; update_note checks (v2.6.5)
|
||||
body = extract_content(replace) if _has_text(replace["content"]) else ""
|
||||
body = localize_inline_images(extract_content(replace)) if _has_text(replace["content"]) else ""
|
||||
changes["content_format"] = content_format(replace) if body else None
|
||||
if "name" in replace:
|
||||
title = extract_title(replace)
|
||||
if "summary" in replace:
|
||||
summary = extract_summary(replace)
|
||||
if "category" in replace:
|
||||
tags = extract_tags(replace)
|
||||
if "photo" in replace:
|
||||
@@ -738,17 +784,22 @@ def handle_update(data: dict, token_info: dict):
|
||||
if "photo" in add:
|
||||
photos += extract_photos(add)
|
||||
|
||||
# Text may go only if photos stay (or it's a like, repost or bookmark) (v2.6.5)
|
||||
if not (body or "").strip() and not (photos or note.reacts_to):
|
||||
raise MicropubValidationError("A post needs text or a photo")
|
||||
# Text may go only if photos stay, it has a title, or it's a like, repost
|
||||
# or bookmark (v2.6.5)
|
||||
if not (body or "").strip() and not (photos or title or note.reacts_to):
|
||||
raise MicropubValidationError("A post needs text, a title or a photo")
|
||||
|
||||
# Photos must all resolve before anything changes (v2.9.0)
|
||||
if "photo" in touched:
|
||||
media_ids, captions = _resolve_photos(photos)
|
||||
|
||||
new_content = add_title_heading(body, title)
|
||||
if new_content != note.content:
|
||||
changes["content"] = new_content
|
||||
if title != note.title:
|
||||
changes["title"] = title
|
||||
if summary != note.summary:
|
||||
changes["summary"] = summary
|
||||
body = drop_title_heading(body, title)
|
||||
if body != note.content:
|
||||
changes["content"] = body
|
||||
elif "content_format" in changes and changes["content_format"] == note.content_format:
|
||||
del changes["content_format"]
|
||||
if {"category"} & touched:
|
||||
@@ -769,6 +820,11 @@ def handle_update(data: dict, token_info: dict):
|
||||
current_app.logger.error(f"Failed to update note via Micropub: {e}")
|
||||
raise MicropubError("server_error", "Failed to update post", status_code=500)
|
||||
|
||||
# Adding or removing a title moves the post between /note/ and /article/:
|
||||
# the spec says to answer 201 with the new URL (v2.17.0)
|
||||
if bool(title) != bool(note.title):
|
||||
from starpunk.utils import post_url
|
||||
return "", 201, {"Location": post_url(note.slug, title)}
|
||||
return "", 204
|
||||
|
||||
|
||||
@@ -800,20 +856,22 @@ def note_to_mf2(note, wanted: Optional[list] = None) -> dict:
|
||||
"""
|
||||
A note as Microformats2 JSON, the inverse of create
|
||||
|
||||
A '# Heading' first line is the title, returned as name.
|
||||
The title is returned as name and the author's summary as summary.
|
||||
"""
|
||||
from starpunk.syndication import get_note_syndications
|
||||
|
||||
title, content = split_title(note.content)
|
||||
content = note.content
|
||||
props = {
|
||||
# HTML-authored content comes back as HTML (3.7.2, v2.9.0)
|
||||
"content": [{"html": content} if note.content_format == "html" else content],
|
||||
"published": [iso_utc(note.created_at)],
|
||||
"url": [absolute_url_for("public.note", slug=note.slug)],
|
||||
"url": [note.url],
|
||||
"post-status": ["published" if note.published else "draft"],
|
||||
}
|
||||
if title:
|
||||
props["name"] = [title]
|
||||
if note.title:
|
||||
props["name"] = [note.title]
|
||||
if note.summary:
|
||||
props["summary"] = [note.summary]
|
||||
from starpunk.tags import get_note_tags
|
||||
|
||||
tags = get_note_tags(note.id, entered_order=True)
|
||||
|
||||
+67
-1
@@ -344,7 +344,65 @@ def apply_migration(conn, migration_name, migration_path, logger=None):
|
||||
raise MigrationError(error_msg)
|
||||
|
||||
|
||||
def run_migrations(db_path, logger=None):
|
||||
def _move_note_titles(conn, data_dir, logger):
|
||||
"""
|
||||
Migration 023 data step: move each note's '# Heading' title into notes.title
|
||||
|
||||
Runs once, inside the migration transaction. Rewrites the note files without
|
||||
the heading and returns [(path, original text)] so a failed migration can
|
||||
put them back (see _restore_files).
|
||||
"""
|
||||
from starpunk.models import split_title
|
||||
from starpunk.utils import calculate_content_hash, find_trashed_file, write_note_file
|
||||
|
||||
data_dir = Path(data_dir)
|
||||
written = []
|
||||
try:
|
||||
rows = conn.execute(
|
||||
"SELECT id, slug, file_path FROM notes WHERE title IS NULL"
|
||||
).fetchall()
|
||||
for note_id, slug, file_path in rows:
|
||||
path = data_dir / file_path
|
||||
if not path.exists():
|
||||
path = find_trashed_file(data_dir, file_path)
|
||||
if path is None:
|
||||
logger.warning(f"Migration 023: no file for note {slug}, title not moved")
|
||||
continue
|
||||
text = path.read_text(encoding="utf-8")
|
||||
title, body = split_title(text)
|
||||
if title is None:
|
||||
continue
|
||||
conn.execute(
|
||||
"UPDATE notes SET title = ?, content_hash = ? WHERE id = ?",
|
||||
(title, calculate_content_hash(body), note_id),
|
||||
)
|
||||
write_note_file(path, body)
|
||||
written.append((path, text))
|
||||
if written and table_exists(conn, "notes_fts"):
|
||||
# Emptied so startup rebuilds it with the titles (starpunk/__init__.py)
|
||||
conn.execute("DELETE FROM notes_fts")
|
||||
logger.info(f"Migration 023: moved {len(written)} titles out of note files")
|
||||
return written
|
||||
except Exception:
|
||||
_restore_files(written, logger)
|
||||
raise
|
||||
|
||||
|
||||
def _restore_files(written, logger):
|
||||
"""Put back note files changed by a data step whose migration failed"""
|
||||
for path, text in written:
|
||||
try:
|
||||
path.write_text(text, encoding="utf-8")
|
||||
except OSError as e:
|
||||
logger.critical(f"Could not restore {path} after failed migration: {e}")
|
||||
|
||||
|
||||
# Python steps run right after a migration's SQL, in the same transaction.
|
||||
# Each returns [(path, original text)] for files it changed.
|
||||
DATA_MIGRATIONS = {"023_note_titles.sql": _move_note_titles}
|
||||
|
||||
|
||||
def run_migrations(db_path, logger=None, data_dir=None):
|
||||
"""
|
||||
Run all pending database migrations with concurrency protection
|
||||
|
||||
@@ -374,6 +432,8 @@ def run_migrations(db_path, logger=None):
|
||||
Args:
|
||||
db_path: Path to SQLite database file
|
||||
logger: Optional logger for output
|
||||
data_dir: Data directory, for migrations that also change note files
|
||||
(DATA_MIGRATIONS); skipped when None
|
||||
|
||||
Raises:
|
||||
MigrationError: If any migration fails to apply or lock cannot be acquired
|
||||
@@ -407,6 +467,7 @@ def run_migrations(db_path, logger=None):
|
||||
# BEGIN IMMEDIATE acquires RESERVED lock, preventing other writes
|
||||
# but allowing reads. Escalates to EXCLUSIVE during actual writes.
|
||||
conn.execute("BEGIN IMMEDIATE")
|
||||
written = [] # note files changed by DATA_MIGRATIONS, restored on failure
|
||||
|
||||
try:
|
||||
# Ensure migrations tracking table exists
|
||||
@@ -510,6 +571,9 @@ def run_migrations(db_path, logger=None):
|
||||
|
||||
# Execute migration inside the locked transaction
|
||||
execute_in_transaction(conn, migration_sql)
|
||||
data_step = DATA_MIGRATIONS.get(migration_name)
|
||||
if data_step and data_dir is not None:
|
||||
written += data_step(conn, data_dir, logger)
|
||||
|
||||
# Record migration as applied
|
||||
conn.execute(
|
||||
@@ -547,6 +611,7 @@ def run_migrations(db_path, logger=None):
|
||||
|
||||
except MigrationError:
|
||||
# Migration error - rollback and re-raise
|
||||
_restore_files(written, logger)
|
||||
try:
|
||||
conn.rollback()
|
||||
except Exception as rollback_error:
|
||||
@@ -556,6 +621,7 @@ def run_migrations(db_path, logger=None):
|
||||
|
||||
except Exception as e:
|
||||
# Unexpected error during migration - rollback and wrap
|
||||
_restore_files(written, logger)
|
||||
try:
|
||||
conn.rollback()
|
||||
except Exception as rollback_error:
|
||||
|
||||
+54
-112
@@ -36,9 +36,9 @@ DEFAULT_AUTH_STATE_EXPIRY_MINUTES = 5
|
||||
DEFAULT_TOKEN_EXPIRY_DAYS = 90
|
||||
|
||||
# Constants - Markdown rendering
|
||||
from starpunk.markdown_ext import BareUrlExtension
|
||||
from starpunk.markdown_ext import BareUrlExtension, HashtagLineExtension
|
||||
|
||||
MARKDOWN_EXTENSIONS = ["extra", "codehilite", "nl2br", BareUrlExtension()]
|
||||
MARKDOWN_EXTENSIONS = ["extra", "codehilite", "nl2br", BareUrlExtension(), HashtagLineExtension()]
|
||||
|
||||
# Constants - Content limits
|
||||
MAX_TITLE_LENGTH = 200
|
||||
@@ -76,11 +76,14 @@ EXCERPT_LENGTH = 200
|
||||
|
||||
def split_title(content: str) -> tuple[Optional[str], str]:
|
||||
"""
|
||||
Split a note's '# Heading' first line (its title, per Q22) off its content
|
||||
Split a '# Heading' first line off Markdown content
|
||||
|
||||
Before v2.16.0 an article's title was its '# Heading' first line (Q22).
|
||||
Titles now live in notes.title (ADR-076); migration 023 uses this to move
|
||||
the old headings there, and Micropub to drop a heading that repeats 'name'.
|
||||
|
||||
The first line must be a Markdown heading: 1-6 '#' then a space and text.
|
||||
'#indieweb ...' (a hashtag) or a bare '#' is not a title. This is the one
|
||||
place that decides whether a note has a title (templates use has_title).
|
||||
'#indieweb ...' (a hashtag) or a bare '#' is not a title.
|
||||
|
||||
Returns:
|
||||
(title, remaining content); title is None if the note has no heading
|
||||
@@ -171,6 +174,8 @@ class Note:
|
||||
repost_of: Optional[str] = None # v2.5.0: URL reposted (this note is a repost)
|
||||
bookmark_of: Optional[str] = None # v2.9.0: URL bookmarked (this note is a bookmark)
|
||||
content_format: Optional[str] = None # v2.9.0: 'html' if sent as HTML via Micropub
|
||||
title: Optional[str] = None # v2.16.0: an article's title (p-name), ADR-076
|
||||
summary: Optional[str] = None # v2.16.0: author-written summary (p-summary)
|
||||
_cached_content: Optional[str] = field(
|
||||
default=None, repr=False, compare=False, init=False
|
||||
)
|
||||
@@ -233,6 +238,8 @@ class Note:
|
||||
repost_of=data.get("repost_of"),
|
||||
bookmark_of=data.get("bookmark_of"),
|
||||
content_format=data.get("content_format"),
|
||||
title=data.get("title"),
|
||||
summary=data.get("summary"),
|
||||
)
|
||||
|
||||
@property
|
||||
@@ -291,8 +298,13 @@ class Note:
|
||||
<p>This is my note content...</p>
|
||||
"""
|
||||
if self._cached_html is None:
|
||||
# Render markdown to sanitized HTML (v2.9.0)
|
||||
html = render_markdown(self.content) # triggers lazy load of content
|
||||
if self.content_format == "html":
|
||||
# Sent as HTML via Micropub: sanitize it as is. Through Markdown
|
||||
# it picked up stray <br>s and empty paragraphs (v2.16.0)
|
||||
html = nh3.clean(self.content, tags=ALLOWED_TAGS, attributes=ALLOWED_ATTRIBUTES)
|
||||
else:
|
||||
# Render markdown to sanitized HTML (v2.9.0)
|
||||
html = render_markdown(self.content) # triggers lazy load of content
|
||||
|
||||
# Cache it
|
||||
object.__setattr__(self, "_cached_html", html)
|
||||
@@ -300,124 +312,40 @@ class Note:
|
||||
return self._cached_html
|
||||
|
||||
@property
|
||||
def body_html(self) -> str:
|
||||
"""
|
||||
Rendered HTML without the title heading
|
||||
|
||||
Pages show a titled note's title as their own heading, so the body
|
||||
leaves it out to avoid showing it twice. Untitled notes: same as html.
|
||||
"""
|
||||
title, body = split_title(self.content)
|
||||
if title is None:
|
||||
return self.html
|
||||
return render_markdown(body)
|
||||
|
||||
@property
|
||||
def has_title(self) -> bool:
|
||||
"""True if the note starts with a '# Heading' title (an article)"""
|
||||
try:
|
||||
return split_title(self.content)[0] is not None
|
||||
except (FileNotFoundError, OSError):
|
||||
return False
|
||||
|
||||
@property
|
||||
def title(self) -> str:
|
||||
"""
|
||||
Extract title from content
|
||||
|
||||
Returns first line of content, or uses slug as fallback.
|
||||
Strips markdown heading syntax (# ) if present.
|
||||
|
||||
Returns:
|
||||
Title string
|
||||
|
||||
Examples:
|
||||
>>> # Content: "# My First Note\\n\\nContent here..."
|
||||
>>> note.title
|
||||
'My First Note'
|
||||
|
||||
>>> # Content: "Just a note without heading"
|
||||
>>> note.title
|
||||
'Just a note without heading'
|
||||
"""
|
||||
try:
|
||||
# Get content (may trigger lazy load)
|
||||
content = self.content
|
||||
|
||||
# Split into lines and get first non-empty line
|
||||
lines = content.strip().split("\n")
|
||||
first_line = ""
|
||||
for line in lines:
|
||||
if line.strip():
|
||||
first_line = line.strip()
|
||||
break
|
||||
|
||||
if not first_line:
|
||||
# No content, use slug
|
||||
return self.slug
|
||||
|
||||
# Strip markdown heading syntax
|
||||
if first_line.startswith("#"):
|
||||
# Remove leading # characters and whitespace
|
||||
first_line = first_line.lstrip("#").strip()
|
||||
|
||||
# Truncate to max length
|
||||
if len(first_line) > MAX_TITLE_LENGTH:
|
||||
first_line = first_line[:MAX_TITLE_LENGTH]
|
||||
|
||||
return first_line if first_line else self.slug
|
||||
|
||||
except (FileNotFoundError, OSError):
|
||||
# If file doesn't exist, use slug
|
||||
return self.slug
|
||||
def label(self) -> str:
|
||||
"""A name for places that always need one: the title, else the excerpt, else the slug"""
|
||||
return self.title or " ".join(self.excerpt.split())[:MAX_TITLE_LENGTH] or self.slug
|
||||
|
||||
@property
|
||||
def excerpt(self) -> str:
|
||||
"""
|
||||
Generate short excerpt for previews
|
||||
|
||||
Returns first 200 characters of content (plain text, no markdown).
|
||||
Strips markdown formatting and adds ellipsis if truncated.
|
||||
The first 200 characters of the note as plain text: Markdown (or
|
||||
HTML) rendered and stripped, images left out, links as their text
|
||||
(v2.16.0). Cut at a word boundary with an ellipsis if longer.
|
||||
|
||||
Returns:
|
||||
Excerpt string
|
||||
|
||||
Examples:
|
||||
>>> note.excerpt
|
||||
'This is my note content. It has some interesting points...'
|
||||
'This is my note content. It has some interesting points…'
|
||||
"""
|
||||
from starpunk.syndication import plain_text
|
||||
|
||||
try:
|
||||
# Leave out the title; previews show it separately
|
||||
_, content = split_title(self.content)
|
||||
|
||||
# Remove markdown heading syntax
|
||||
lines = content.split("\n")
|
||||
cleaned_lines = []
|
||||
for line in lines:
|
||||
if line.strip().startswith("#"):
|
||||
# Remove heading syntax
|
||||
cleaned_lines.append(line.lstrip("#").strip())
|
||||
else:
|
||||
cleaned_lines.append(line)
|
||||
|
||||
cleaned_content = "\n".join(cleaned_lines)
|
||||
|
||||
# Take first EXCERPT_LENGTH characters
|
||||
excerpt = cleaned_content.strip()[:EXCERPT_LENGTH]
|
||||
|
||||
# Truncate to word boundary
|
||||
if len(cleaned_content.strip()) > EXCERPT_LENGTH:
|
||||
# Find last space in excerpt
|
||||
text = " ".join(plain_text(self.content).split())
|
||||
if len(text) > EXCERPT_LENGTH:
|
||||
excerpt = text[:EXCERPT_LENGTH]
|
||||
last_space = excerpt.rfind(" ")
|
||||
if last_space > 0:
|
||||
excerpt = excerpt[:last_space]
|
||||
excerpt += "..."
|
||||
text = (excerpt[:last_space] if last_space > 0 else excerpt).rstrip() + "…"
|
||||
|
||||
if not excerpt and self.reacts_to:
|
||||
if not text and self.reacts_to:
|
||||
# A like, repost or bookmark with no comment
|
||||
return f"{REACTION_VERBS[self.kind]} {self.reacts_to}"
|
||||
|
||||
return excerpt
|
||||
return text
|
||||
|
||||
except (FileNotFoundError, OSError):
|
||||
# If file doesn't exist, return slug
|
||||
@@ -455,14 +383,27 @@ class Note:
|
||||
"""
|
||||
Generate permalink (public URL path)
|
||||
|
||||
Returns:
|
||||
URL path string (e.g., '/note/my-first-note')
|
||||
Articles (notes with a title) live under /article/, other notes
|
||||
under /note/ (v2.17.0).
|
||||
|
||||
Examples:
|
||||
>>> note.permalink
|
||||
'/note/my-first-note'
|
||||
Returns:
|
||||
URL path string (e.g., '/note/my-first-note', '/article/my-essay')
|
||||
"""
|
||||
return f"/note/{self.slug}"
|
||||
from starpunk.utils import post_path
|
||||
|
||||
return post_path(self.slug, self.title)
|
||||
|
||||
@property
|
||||
def endpoint(self) -> str:
|
||||
"""The route that shows this note: public.article or public.note (v2.17.0)"""
|
||||
return "public.article" if self.title else "public.note"
|
||||
|
||||
@property
|
||||
def url(self) -> str:
|
||||
"""Absolute permalink, built from SITE_URL (needs an app context)"""
|
||||
from starpunk.utils import post_url
|
||||
|
||||
return post_url(self.slug, self.title)
|
||||
|
||||
@property
|
||||
def is_published(self) -> bool:
|
||||
@@ -533,6 +474,7 @@ class Note:
|
||||
"id": self.id,
|
||||
"slug": self.slug,
|
||||
"title": self.title,
|
||||
"summary": self.summary,
|
||||
"published": self.published,
|
||||
"created_at": self.created_at.strftime("%Y-%m-%dT%H:%M:%SZ"),
|
||||
"updated_at": self.updated_at.strftime("%Y-%m-%dT%H:%M:%SZ"),
|
||||
|
||||
+49
-26
@@ -40,6 +40,7 @@ from starpunk.utils import (
|
||||
calculate_content_hash,
|
||||
validate_note_path,
|
||||
validate_slug,
|
||||
post_url,
|
||||
)
|
||||
|
||||
|
||||
@@ -149,6 +150,8 @@ def create_note(
|
||||
has_media: bool = False,
|
||||
bookmark_of: Optional[str] = None,
|
||||
content_format: Optional[str] = None,
|
||||
title: Optional[str] = None,
|
||||
summary: Optional[str] = None,
|
||||
) -> Note:
|
||||
"""
|
||||
Create a new note
|
||||
@@ -164,6 +167,8 @@ def create_note(
|
||||
custom_slug: Optional custom slug (from Micropub mp-slug property)
|
||||
tags: Optional list of tag display names (v1.3.0)
|
||||
in_reply_to: Optional URL being replied to (v1.6.0)
|
||||
title: Optional title; a titled note is an article (v2.16.0, ADR-076)
|
||||
summary: Optional author-written summary (v2.16.0)
|
||||
|
||||
Returns:
|
||||
Note object with all metadata and content loaded
|
||||
@@ -176,7 +181,7 @@ def create_note(
|
||||
|
||||
Examples:
|
||||
>>> # Create unpublished draft
|
||||
>>> note = create_note("# My First Note\\n\\nContent here.", published=False)
|
||||
>>> note = create_note("Content here.", title="My First Note", published=False)
|
||||
>>> print(note.slug)
|
||||
'my-first-note'
|
||||
|
||||
@@ -219,7 +224,9 @@ def create_note(
|
||||
"like_of", like_of, "A note can only be one of a like, repost or bookmark"
|
||||
)
|
||||
content = content or ""
|
||||
if not content.strip() and not (like_of or repost_of or bookmark_of or has_media):
|
||||
title = (title or "").strip() or None
|
||||
summary = (summary or "").strip() or None
|
||||
if not content.strip() and not (like_of or repost_of or bookmark_of or has_media or title):
|
||||
raise InvalidNoteDataError(
|
||||
"content", content, "Content cannot be empty or whitespace-only"
|
||||
)
|
||||
@@ -244,9 +251,11 @@ def create_note(
|
||||
if not success:
|
||||
raise InvalidNoteDataError("slug", custom_slug, error)
|
||||
else:
|
||||
# Generate timestamp-based slug (ADR-062)
|
||||
from starpunk.slug_utils import generate_timestamp_slug
|
||||
slug = generate_timestamp_slug(created_at, existing_slugs)
|
||||
# Articles take their slug from the title (v2.17.0); other notes, or a
|
||||
# title with nothing usable in it, get a timestamp slug (ADR-062)
|
||||
from starpunk.slug_utils import generate_timestamp_slug, generate_title_slug
|
||||
slug = (generate_title_slug(title, existing_slugs) if title else None) \
|
||||
or generate_timestamp_slug(created_at, existing_slugs)
|
||||
|
||||
# 4. GENERATE FILE PATH
|
||||
note_path = generate_note_path(slug, created_at, data_dir)
|
||||
@@ -281,11 +290,12 @@ def create_note(
|
||||
db.execute(
|
||||
"""
|
||||
INSERT INTO notes (slug, file_path, published, created_at, updated_at, content_hash,
|
||||
in_reply_to, like_of, repost_of, bookmark_of, content_format)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
|
||||
in_reply_to, like_of, repost_of, bookmark_of, content_format,
|
||||
title, summary)
|
||||
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
|
||||
""",
|
||||
(slug, file_path_rel, published, created_at, updated_at, content_hash,
|
||||
in_reply_to, like_of, repost_of, bookmark_of, content_format),
|
||||
in_reply_to, like_of, repost_of, bookmark_of, content_format, title, summary),
|
||||
)
|
||||
db.commit()
|
||||
except Exception as e:
|
||||
@@ -327,7 +337,7 @@ def create_note(
|
||||
from starpunk.search import update_fts_index, has_fts_table
|
||||
db_path = Path(current_app.config["DATABASE_PATH"])
|
||||
if has_fts_table(db_path):
|
||||
update_fts_index(db, note_id, slug, content)
|
||||
update_fts_index(db, note_id, slug, content, title)
|
||||
db.commit()
|
||||
except Exception as e:
|
||||
# FTS update failure should not prevent note creation
|
||||
@@ -341,7 +351,7 @@ def create_note(
|
||||
db_path = Path(current_app.config["DATABASE_PATH"])
|
||||
site_url = current_app.config["SITE_URL"]
|
||||
from starpunk.utils import absolute_url_for
|
||||
note_url = absolute_url_for("public.note", slug=slug)
|
||||
note_url = post_url(slug, title)
|
||||
|
||||
# Get rendered HTML from note
|
||||
html_content = note.html
|
||||
@@ -641,11 +651,14 @@ def update_note(
|
||||
in_reply_to: Optional[str] = None,
|
||||
has_media: bool = False,
|
||||
content_format=UNCHANGED,
|
||||
title=UNCHANGED,
|
||||
summary=UNCHANGED,
|
||||
) -> Note:
|
||||
"""
|
||||
Update a note's content and/or published status
|
||||
|
||||
content_format (v2.9.0): 'html' or None (Markdown); left alone unless given
|
||||
title, summary (v2.16.0): new value, None or "" to remove; left alone unless given
|
||||
|
||||
Updates note content and/or metadata, maintaining atomic synchronization
|
||||
between file and database. At least one of content or published must
|
||||
@@ -713,8 +726,15 @@ def update_note(
|
||||
if slug is not None and id is not None:
|
||||
raise ValueError("Cannot provide both slug and id")
|
||||
|
||||
if content is None and published is None and tags is None and in_reply_to is None:
|
||||
raise ValueError("Must provide at least one of content, published, tags, or in_reply_to to update")
|
||||
if (content is None and published is None and tags is None and in_reply_to is None
|
||||
and title is UNCHANGED and summary is UNCHANGED):
|
||||
raise ValueError(
|
||||
"Must provide at least one of content, published, tags, in_reply_to, title or summary to update"
|
||||
)
|
||||
if title is not UNCHANGED:
|
||||
title = (title or "").strip() or None
|
||||
if summary is not UNCHANGED:
|
||||
summary = (summary or "").strip() or None
|
||||
|
||||
# Validate content if provided (checked against the note below for
|
||||
# likes/reposts, whose comment may be empty)
|
||||
@@ -729,7 +749,8 @@ def update_note(
|
||||
raise NoteNotFoundError(identifier)
|
||||
old_tag_names = _tag_names(existing_note.id) # for WebSub tag topics (v2.10.0)
|
||||
|
||||
if empty_content and not (existing_note.reacts_to or has_media):
|
||||
new_title = existing_note.title if title is UNCHANGED else title
|
||||
if empty_content and not (existing_note.reacts_to or has_media or new_title):
|
||||
raise InvalidNoteDataError(
|
||||
"content", content, "Content cannot be empty or whitespace-only"
|
||||
)
|
||||
@@ -797,6 +818,14 @@ def update_note(
|
||||
update_fields.append("content_format = ?")
|
||||
params.append(content_format)
|
||||
|
||||
if title is not UNCHANGED:
|
||||
update_fields.append("title = ?")
|
||||
params.append(title)
|
||||
|
||||
if summary is not UNCHANGED:
|
||||
update_fields.append("summary = ?")
|
||||
params.append(summary)
|
||||
|
||||
# Add WHERE clause parameter
|
||||
if slug is not None:
|
||||
where_clause = "slug = ?"
|
||||
@@ -832,13 +861,14 @@ def update_note(
|
||||
# Tag update failure should not prevent note update
|
||||
current_app.logger.warning(f"Failed to update tags for note {existing_note.slug}: {e}")
|
||||
|
||||
# 7. UPDATE FTS INDEX (if available and content changed)
|
||||
if content is not None:
|
||||
# 7. UPDATE FTS INDEX (if available and content or title changed)
|
||||
if content is not None or title is not UNCHANGED:
|
||||
try:
|
||||
from starpunk.search import update_fts_index, has_fts_table
|
||||
db_path = Path(current_app.config["DATABASE_PATH"])
|
||||
if has_fts_table(db_path):
|
||||
update_fts_index(db, existing_note.id, existing_note.slug, content)
|
||||
update_fts_index(db, existing_note.id, existing_note.slug,
|
||||
existing_note.content if content is None else content, new_title)
|
||||
db.commit()
|
||||
except Exception as e:
|
||||
# FTS update failure should not prevent note update
|
||||
@@ -876,7 +906,7 @@ def update_note(
|
||||
db_path = Path(current_app.config["DATABASE_PATH"])
|
||||
site_url = current_app.config["SITE_URL"]
|
||||
from starpunk.utils import absolute_url_for
|
||||
note_url = absolute_url_for("public.note", slug=updated_note.slug)
|
||||
note_url = updated_note.url
|
||||
|
||||
# Get rendered HTML from updated note (if published)
|
||||
html_content = updated_note.html if updated_note.published else None
|
||||
@@ -1129,7 +1159,7 @@ def undelete_note(slug: str) -> Note:
|
||||
NoteNotFoundError: If there is no soft-deleted note with this slug
|
||||
"""
|
||||
import shutil
|
||||
from starpunk.utils import TRASH_DIR_NAME
|
||||
from starpunk.utils import find_trashed_file
|
||||
|
||||
db = get_db(current_app)
|
||||
row = db.execute(
|
||||
@@ -1142,14 +1172,7 @@ def undelete_note(slug: str) -> Note:
|
||||
data_dir = Path(current_app.config["DATA_PATH"])
|
||||
note_path = data_dir / row["file_path"]
|
||||
if not note_path.exists():
|
||||
# delete_note_file put it in .trash/<year>/<month>/<name>
|
||||
parts = Path(row["file_path"]).parts
|
||||
candidates = []
|
||||
if "notes" in parts and len(parts) > parts.index("notes") + 2:
|
||||
i = parts.index("notes")
|
||||
candidates.append(data_dir / TRASH_DIR_NAME / parts[i + 1] / parts[i + 2] / note_path.name)
|
||||
candidates += sorted((data_dir / TRASH_DIR_NAME).glob(f"*/*/{note_path.name}"))
|
||||
source = next((c for c in candidates if c.exists()), None)
|
||||
source = find_trashed_file(data_dir, row["file_path"])
|
||||
if source is None:
|
||||
raise NoteSyncError("undelete", f"Trashed file not found for {slug}", "Cannot restore note file")
|
||||
note_path.parent.mkdir(parents=True, exist_ok=True)
|
||||
|
||||
@@ -24,6 +24,8 @@ import time
|
||||
from typing import Dict, List, Optional, Tuple
|
||||
from urllib.parse import parse_qsl, urlsplit
|
||||
|
||||
from starpunk.utils import post_path
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
RESPONSE_EVENTS = ("reply", "mention", "quote", "like", "repost", "bookmark")
|
||||
@@ -142,7 +144,7 @@ def _note_label(conn, note_id: int) -> str:
|
||||
|
||||
try:
|
||||
note = get_note(id=note_id, load_content=True)
|
||||
label = " ".join((note.title or "").split()) if note else ""
|
||||
label = note.label if note else ""
|
||||
except Exception:
|
||||
label = ""
|
||||
return (label[:57] + "…") if len(label) > 60 else (label or "a note")
|
||||
@@ -158,7 +160,7 @@ def _messages(rows, site_url: str, conn) -> List[Tuple[str, str, List[int]]]:
|
||||
who = (row["author_name"] or "someone") + (f" via {via}" if via else "")
|
||||
pending = row["moderation_status"] == "pending"
|
||||
link = (f"{site}/admin/webmentions/{row['id']}" if pending
|
||||
else f"{site}/note/{row['slug']}#responses")
|
||||
else f"{site}{post_path(row['slug'], row['note_title'])}#responses")
|
||||
if row["mention_type"] in GROUPED:
|
||||
groups.setdefault((row["target_note_id"], row["mention_type"], row["slug"], pending), []).append(
|
||||
(row["id"], row["author_name"] or "someone", link))
|
||||
@@ -206,7 +208,7 @@ class Sweeper:
|
||||
logger.warning(f"Dropped {dropped} notification(s) older than {DROP_AFTER_HOURS} hours")
|
||||
rows = conn.execute(
|
||||
"""
|
||||
SELECT w.*, n.slug FROM webmentions w JOIN notes n ON n.id = w.target_note_id
|
||||
SELECT w.*, n.slug, n.title AS note_title FROM webmentions w JOIN notes n ON n.id = w.target_note_id
|
||||
WHERE w.notified_at IS NULL AND w.validation_status = 'valid'
|
||||
AND w.moderation_status IN ('approved', 'pending')
|
||||
ORDER BY w.id LIMIT 100
|
||||
|
||||
+52
-10
@@ -25,6 +25,20 @@ from starpunk.notes import (
|
||||
bp = Blueprint("admin", __name__, url_prefix="/admin")
|
||||
|
||||
|
||||
@bp.context_processor
|
||||
def _admin_nav():
|
||||
"""Error count for the Log link in the admin nav (v2.18.0)"""
|
||||
if not getattr(g, "me", None):
|
||||
return {}
|
||||
from starpunk import error_log
|
||||
|
||||
try:
|
||||
return {"error_count": error_log.count()}
|
||||
except Exception as e: # never break an admin page over the badge
|
||||
logger.warning(f"Could not count errors for the admin nav: {e}")
|
||||
return {"error_count": 0}
|
||||
|
||||
|
||||
@bp.route("/")
|
||||
@require_auth
|
||||
def dashboard():
|
||||
@@ -128,6 +142,7 @@ def create_note_submit():
|
||||
media_files: Multiple file upload (v1.2.0 Phase 3)
|
||||
captions[]: Captions for each media file (v1.2.0 Phase 3)
|
||||
tags: Comma-separated tag list (v1.3.0 Phase 3)
|
||||
title, summary: Optional; a title makes it an article (v2.16.0)
|
||||
|
||||
Returns:
|
||||
Redirect to dashboard on success, back to form on error
|
||||
@@ -141,17 +156,19 @@ def create_note_submit():
|
||||
published = "published" in request.form
|
||||
custom_slug = request.form.get("custom_slug", "").strip()
|
||||
tags_input = request.form.get("tags", "")
|
||||
title = request.form.get("title", "").strip() or None
|
||||
summary = request.form.get("summary", "").strip() or None
|
||||
|
||||
if not content:
|
||||
flash("Content cannot be empty", "error")
|
||||
# With photos, WebSub hears about the note once they're attached (v2.10.1)
|
||||
has_uploads = any(f.filename for f in request.files.getlist('media_files'))
|
||||
|
||||
if not (content or title or has_uploads):
|
||||
flash("A note needs text, a title or an image", "error")
|
||||
return redirect(url_for("admin.new_note_form"))
|
||||
|
||||
# Parse tags (v1.3.0 Phase 3)
|
||||
tags = parse_tag_input(tags_input)
|
||||
|
||||
# With photos, WebSub hears about the note once they're attached (v2.10.1)
|
||||
has_uploads = any(f.filename for f in request.files.getlist('media_files'))
|
||||
|
||||
try:
|
||||
# Create note first (per Q4)
|
||||
note = create_note(
|
||||
@@ -160,6 +177,8 @@ def create_note_submit():
|
||||
custom_slug=custom_slug if custom_slug else None,
|
||||
tags=tags if tags else None,
|
||||
has_media=has_uploads,
|
||||
title=title,
|
||||
summary=summary,
|
||||
)
|
||||
|
||||
# Handle media uploads (v1.2.0 Phase 3)
|
||||
@@ -279,12 +298,14 @@ def update_note_submit(note_id: int):
|
||||
content: Updated markdown content (required)
|
||||
published: Checkbox for published status (optional)
|
||||
tags: Comma-separated tag list (v1.3.0 Phase 3)
|
||||
title, summary: Empty removes them; a form without the field leaves them (v2.16.0)
|
||||
|
||||
Returns:
|
||||
Redirect to dashboard on success, back to form on error
|
||||
|
||||
Decorator: @require_auth
|
||||
"""
|
||||
from starpunk.notes import UNCHANGED
|
||||
from starpunk.tags import parse_tag_input
|
||||
|
||||
# Check if note exists first
|
||||
@@ -296,8 +317,12 @@ def update_note_submit(note_id: int):
|
||||
content = request.form.get("content", "").strip()
|
||||
published = "published" in request.form
|
||||
tags_input = request.form.get("tags", "")
|
||||
title = request.form["title"].strip() if "title" in request.form else UNCHANGED
|
||||
summary = request.form["summary"].strip() if "summary" in request.form else UNCHANGED
|
||||
has_title = existing_note.title if title is UNCHANGED else title
|
||||
|
||||
if not content and not existing_note.reacts_to: # likes/reposts may have no comment
|
||||
# Likes/reposts may have no comment, articles no body
|
||||
if not content and not (existing_note.reacts_to or has_title):
|
||||
flash("Content cannot be empty", "error")
|
||||
return redirect(url_for("admin.edit_note_form", note_id=note_id))
|
||||
|
||||
@@ -311,7 +336,9 @@ def update_note_submit(note_id: int):
|
||||
published=published,
|
||||
# An empty Tags field removes all tags (v2.14.1); a form without
|
||||
# the field leaves them alone
|
||||
tags=tags if "tags" in request.form else None
|
||||
tags=tags if "tags" in request.form else None,
|
||||
title=title,
|
||||
summary=summary,
|
||||
)
|
||||
if "syndication_form" in request.form:
|
||||
from starpunk.syndication import select_targets
|
||||
@@ -517,7 +544,6 @@ def webmentions():
|
||||
status_filter=status_filter,
|
||||
origin_filter=origin_filter,
|
||||
backfeed=backfeed.status(),
|
||||
notify=_notify_status(),
|
||||
page=page,
|
||||
total_pages=total_pages,
|
||||
user_me=g.me
|
||||
@@ -685,7 +711,7 @@ def revoke_token(token_id):
|
||||
|
||||
|
||||
def _notify_status() -> dict:
|
||||
"""Notification settings and last error for the Webmentions page (v2.14.0)"""
|
||||
"""Notification settings and last error for the Settings page (v2.14.0)"""
|
||||
from starpunk import notifications
|
||||
from starpunk.database import get_db
|
||||
|
||||
@@ -698,6 +724,22 @@ def _notify_status() -> dict:
|
||||
}
|
||||
|
||||
|
||||
@bp.route("/settings")
|
||||
@require_auth
|
||||
def settings():
|
||||
"""Site settings: notifications (v2.18.0). Template: templates/admin/settings.html"""
|
||||
return render_template("admin/settings.html", notify=_notify_status(), user_me=g.me)
|
||||
|
||||
|
||||
@bp.route("/log")
|
||||
@require_auth
|
||||
def error_log():
|
||||
"""Current errors with the affected note (v2.18.0). Template: templates/admin/log.html"""
|
||||
from starpunk import error_log as log
|
||||
|
||||
return render_template("admin/log.html", entries=log.entries(), user_me=g.me)
|
||||
|
||||
|
||||
@bp.route("/notifications/test", methods=["POST"])
|
||||
@require_auth
|
||||
def notifications_test():
|
||||
@@ -709,7 +751,7 @@ def notifications_test():
|
||||
notifications._record(current_app.config["DATABASE_PATH"], ok, error)
|
||||
flash("Test notification sent" if ok else f"Test notification failed: {error or 'unknown error'}",
|
||||
"success" if ok else "error")
|
||||
return redirect(url_for("admin.webmentions"))
|
||||
return redirect(url_for("admin.settings"))
|
||||
|
||||
|
||||
@bp.route("/backfeed/backfill", methods=["POST"])
|
||||
|
||||
@@ -8,7 +8,7 @@ No authentication required for these routes.
|
||||
import hashlib
|
||||
from datetime import datetime, timedelta, timezone
|
||||
|
||||
from flask import Blueprint, abort, render_template, Response, current_app, request, send_from_directory
|
||||
from flask import Blueprint, abort, redirect, render_template, Response, current_app, request, send_from_directory, url_for
|
||||
|
||||
from starpunk.notes import list_notes, get_note
|
||||
from starpunk.websub import embed_hub
|
||||
@@ -354,18 +354,30 @@ def _note_was_deleted(slug: str) -> bool:
|
||||
).fetchone():
|
||||
return True
|
||||
return db.execute(
|
||||
"SELECT 1 FROM webmention_queue WHERE source_url = ? AND source_note_id IS NULL",
|
||||
(absolute_url_for("public.note", slug=slug),),
|
||||
"SELECT 1 FROM webmention_queue WHERE source_url IN (?, ?) AND source_note_id IS NULL",
|
||||
(absolute_url_for("public.note", slug=slug), absolute_url_for("public.article", slug=slug)),
|
||||
).fetchone() is not None
|
||||
|
||||
|
||||
@bp.route("/note/<slug>")
|
||||
def note(slug: str):
|
||||
"""A note's permalink page; an article's /note/ URL redirects to /article/"""
|
||||
return _permalink(slug, "public.note")
|
||||
|
||||
|
||||
@bp.route("/article/<slug>")
|
||||
def article(slug: str):
|
||||
"""An article's permalink page (v2.17.0); a note's /article/ URL redirects to /note/"""
|
||||
return _permalink(slug, "public.article")
|
||||
|
||||
|
||||
def _permalink(slug: str, endpoint: str):
|
||||
"""
|
||||
Individual note permalink page
|
||||
Individual note or article permalink page
|
||||
|
||||
Args:
|
||||
slug: URL-safe note identifier
|
||||
endpoint: The route the request came in on
|
||||
|
||||
Returns:
|
||||
Rendered note template with full content
|
||||
@@ -390,6 +402,12 @@ def note(slug: str):
|
||||
abort(410)
|
||||
abort(404)
|
||||
|
||||
# Each post has one URL: /article/ for articles, /note/ for notes (v2.17.0).
|
||||
# The other one redirects, so links made before a title was added or
|
||||
# removed keep working.
|
||||
if note_obj.endpoint != endpoint:
|
||||
return redirect(url_for(note_obj.endpoint, slug=slug), code=301)
|
||||
|
||||
# Get media for note (v1.2.0 Phase 3)
|
||||
media = get_note_media(note_obj.id)
|
||||
|
||||
|
||||
@@ -10,6 +10,7 @@ from pathlib import Path
|
||||
from flask import Blueprint, current_app, g, jsonify, render_template, request
|
||||
|
||||
from starpunk.search import has_fts_table, search_notes
|
||||
from starpunk.utils import post_path
|
||||
|
||||
logger = logging.getLogger(__name__)
|
||||
|
||||
@@ -108,7 +109,7 @@ def api_search():
|
||||
"title": r["title"] or f"Note from {r['created_at'][:10]}",
|
||||
"excerpt": r["snippet"], # Already has <mark> tags
|
||||
"published_at": r["created_at"],
|
||||
"url": f"/note/{r['slug']}",
|
||||
"url": post_path(r["slug"], r.get("article_title")),
|
||||
}
|
||||
for r in results
|
||||
],
|
||||
@@ -176,7 +177,7 @@ def search_page():
|
||||
"title": r["title"] or f"Note from {r['created_at'][:10]}",
|
||||
"excerpt": Markup(safe_snippet), # Mark as safe since we've escaped it ourselves
|
||||
"published_at": r["created_at"],
|
||||
"url": f"/note/{r['slug']}",
|
||||
"url": post_path(r["slug"], r.get("article_title")),
|
||||
})
|
||||
results = formatted_results
|
||||
except Exception as e:
|
||||
|
||||
@@ -139,9 +139,10 @@ def resolve_target_note(target_url: str) -> int | None:
|
||||
# Strip query params and fragments for matching
|
||||
target_path = target_parsed.path.rstrip('/')
|
||||
|
||||
# Check if it's a note URL pattern: /note/{slug}
|
||||
if target_path.startswith('/note/'):
|
||||
slug = target_path[6:] # Remove '/note/' prefix
|
||||
# A note or article URL: /note/{slug} or /article/{slug} (v2.17.0).
|
||||
# Either prefix finds the post, as the page redirects to the right one.
|
||||
prefix, _, slug = target_path.lstrip('/').partition('/')
|
||||
if prefix in ('note', 'article') and '/' not in slug:
|
||||
if slug:
|
||||
try:
|
||||
note = get_note(slug=slug)
|
||||
|
||||
+23
-20
@@ -98,29 +98,32 @@ def has_fts_table(db_path: Path) -> bool:
|
||||
return False
|
||||
|
||||
|
||||
def update_fts_index(conn: sqlite3.Connection, note_id: int, slug: str, content: str):
|
||||
def _first_line(content: str) -> str:
|
||||
"""A note's first line without heading marks (result label for untitled notes).
|
||||
A hashtag ('#indieweb ...') is kept."""
|
||||
line = content.split('\n', 1)[0].strip()
|
||||
return re.sub(r'^#{1,6}\s+', '', line)
|
||||
|
||||
|
||||
def update_fts_index(conn: sqlite3.Connection, note_id: int, slug: str, content: str,
|
||||
title: Optional[str] = None):
|
||||
"""
|
||||
Update FTS index for a note (insert or replace)
|
||||
|
||||
Extracts title from first line of content and updates the FTS index.
|
||||
Uses REPLACE to handle both new notes and updates.
|
||||
Indexes the note's title (articles, v2.16.0) or, for untitled notes, its
|
||||
first line. Uses REPLACE to handle both new notes and updates.
|
||||
|
||||
Args:
|
||||
conn: SQLite database connection
|
||||
note_id: Note ID (used as FTS rowid)
|
||||
slug: Note slug
|
||||
content: Full markdown content
|
||||
content: Markdown content
|
||||
title: The note's title, if it has one
|
||||
|
||||
Raises:
|
||||
sqlite3.Error: If FTS update fails
|
||||
"""
|
||||
# Extract title from first line
|
||||
lines = content.split('\n', 1)
|
||||
title = lines[0].strip() if lines else ''
|
||||
|
||||
# Remove markdown heading syntax (# ## ###)
|
||||
if title.startswith('#'):
|
||||
title = title.lstrip('#').strip()
|
||||
title = title or _first_line(content)
|
||||
|
||||
# Limit title length
|
||||
if len(title) > 100:
|
||||
@@ -170,7 +173,7 @@ def rebuild_fts_index(db_path: Path, data_dir: Path):
|
||||
|
||||
# Get all non-deleted notes
|
||||
cursor = conn.execute(
|
||||
"SELECT id, slug, file_path FROM notes WHERE deleted_at IS NULL"
|
||||
"SELECT id, slug, file_path, title FROM notes WHERE deleted_at IS NULL"
|
||||
)
|
||||
|
||||
indexed_count = 0
|
||||
@@ -188,7 +191,7 @@ def rebuild_fts_index(db_path: Path, data_dir: Path):
|
||||
content = note_path.read_text(encoding='utf-8')
|
||||
|
||||
# Update FTS index
|
||||
update_fts_index(conn, row['id'], row['slug'], content)
|
||||
update_fts_index(conn, row['id'], row['slug'], content, row['title'])
|
||||
indexed_count += 1
|
||||
|
||||
except Exception as e:
|
||||
@@ -327,6 +330,7 @@ def search_notes_fts5(
|
||||
notes.id,
|
||||
notes.slug,
|
||||
notes_fts.title,
|
||||
notes.title AS article_title,
|
||||
notes.published,
|
||||
notes.created_at,
|
||||
rank AS relevance,
|
||||
@@ -353,6 +357,7 @@ def search_notes_fts5(
|
||||
'id': row['id'],
|
||||
'slug': row['slug'],
|
||||
'title': row['title'],
|
||||
'article_title': row['article_title'],
|
||||
'snippet': row['snippet'], # Plain string - route must escape HTML while preserving <mark> tags
|
||||
'relevance': row['relevance'],
|
||||
'published': bool(row['published']),
|
||||
@@ -408,6 +413,7 @@ def search_notes_fallback(
|
||||
id,
|
||||
slug,
|
||||
file_path,
|
||||
title,
|
||||
published,
|
||||
created_at
|
||||
FROM notes
|
||||
@@ -446,8 +452,8 @@ def search_notes_fallback(
|
||||
file_path = data_dir / row['file_path']
|
||||
content = read_note_file(file_path)
|
||||
|
||||
# Check if query matches content (case-insensitive)
|
||||
content_lower = content.lower()
|
||||
# Check if query matches title or content (case-insensitive)
|
||||
content_lower = f"{row['title'] or ''}\n{content}".lower()
|
||||
query_lower = query.lower()
|
||||
matches = query_lower in content_lower
|
||||
|
||||
@@ -456,16 +462,13 @@ def search_notes_fallback(
|
||||
matches = any(term.lower() in content_lower for term in terms)
|
||||
|
||||
if matches:
|
||||
# Extract title from first line
|
||||
lines = content.split('\n', 1)
|
||||
title = lines[0].strip() if lines else row['slug']
|
||||
if title.startswith('#'):
|
||||
title = title.lstrip('#').strip()
|
||||
title = row['title'] or _first_line(content) or row['slug']
|
||||
|
||||
results.append({
|
||||
'id': row['id'],
|
||||
'slug': row['slug'],
|
||||
'title': title,
|
||||
'article_title': row['title'],
|
||||
'snippet': generate_snippet(content, query),
|
||||
'relevance': 0.0, # No ranking in fallback mode
|
||||
'published': bool(row['published']),
|
||||
|
||||
@@ -288,6 +288,35 @@ def generate_timestamp_slug(
|
||||
return f"{base_slug}-{suffix}"
|
||||
|
||||
|
||||
TITLE_SLUG_LENGTH = 80
|
||||
|
||||
|
||||
def generate_title_slug(title: str, existing_slugs: Set[str]) -> Optional[str]:
|
||||
"""
|
||||
A slug made from an article's title (v2.17.0)
|
||||
|
||||
"Why I Left Twitter" becomes 'why-i-left-twitter'; long titles are cut at
|
||||
a word boundary, and a taken slug gets -2, -3, ...
|
||||
|
||||
Returns:
|
||||
The slug, or None when the title has nothing usable (e.g. only emoji),
|
||||
so the caller falls back to a timestamp slug.
|
||||
"""
|
||||
slug = sanitize_slug(title or "")
|
||||
if len(slug) > TITLE_SLUG_LENGTH:
|
||||
cut = slug[:TITLE_SLUG_LENGTH + 1]
|
||||
slug = cut.rsplit("-", 1)[0] if "-" in cut else slug[:TITLE_SLUG_LENGTH]
|
||||
slug = slug.strip("-")
|
||||
if not slug:
|
||||
return None
|
||||
if is_reserved_slug(slug):
|
||||
slug = f"{slug}-article"
|
||||
try:
|
||||
return make_slug_unique_with_suffix(slug, existing_slugs)
|
||||
except ValueError: # 99 articles with this title
|
||||
return None
|
||||
|
||||
|
||||
def validate_and_sanitize_custom_slug(custom_slug: str, existing_slugs: Set[str]) -> tuple[bool, Optional[str], Optional[str]]:
|
||||
"""
|
||||
Validate and sanitize a custom slug from Micropub
|
||||
|
||||
+27
-8
@@ -357,7 +357,9 @@ class BlueskyClient:
|
||||
def _record(self, post: "Post", text: Optional[str] = None, embed: Optional[dict] = None,
|
||||
anchors: List[tuple] = ()) -> dict:
|
||||
if text is None:
|
||||
body, anchors = plain_text_links(post.note.content, links="anchor")
|
||||
# An article is posted as a teaser (compose_text), so its links aren't in the text
|
||||
body, anchors = (None, []) if post.note.title else \
|
||||
plain_text_links(post.note.content, links="anchor")
|
||||
text = compose_text(post.note, post.permalink, post.tags, post.max_chars, body=body)
|
||||
record = {"$type": self.POST, "text": text, "createdAt": self._now()}
|
||||
facets = bluesky_facets(text, anchors)
|
||||
@@ -368,14 +370,16 @@ class BlueskyClient:
|
||||
elif post.media:
|
||||
record["embed"] = {"$type": "app.bsky.embed.images",
|
||||
"images": [self._image(m) for m in post.media]}
|
||||
elif note_links(post.note.content):
|
||||
elif not post.note.title and note_links(post.note.content):
|
||||
# The note links somewhere: the card shows that page, not the note
|
||||
record["embed"] = self._link_card(note_links(post.note.content)[0])
|
||||
else:
|
||||
# Articles always get a card for the article itself (v2.16.0)
|
||||
description = article_teaser(post.note) if post.note.title else plain_text(post.note.content)
|
||||
record["embed"] = {"$type": "app.bsky.embed.external", "external": {
|
||||
"uri": post.permalink,
|
||||
"title": post.note.title[:300],
|
||||
"description": plain_text(post.note.content)[:300],
|
||||
"title": post.note.label[:300],
|
||||
"description": description[:300],
|
||||
}}
|
||||
return record
|
||||
|
||||
@@ -1185,19 +1189,30 @@ def _hashtag(display_name: str) -> str:
|
||||
return f"#{word}" if word else ""
|
||||
|
||||
|
||||
def article_teaser(note) -> str:
|
||||
"""An article's summary, or the start of its text (v2.16.0)"""
|
||||
return note.summary or note.excerpt
|
||||
|
||||
|
||||
def compose_text(note, permalink: str, tags: List[str], max_chars: int,
|
||||
body: Optional[str] = None) -> str:
|
||||
"""
|
||||
Full note (Markdown unless `body` is given), then the permalink and
|
||||
hashtags; shortened at a word boundary if too long. On short targets the
|
||||
hashtags may use at most a third of the space.
|
||||
|
||||
An article (a note with a title) is posted as its title and teaser
|
||||
instead of its full text, the usual POSSE form for articles (v2.16.0).
|
||||
"""
|
||||
hashtags = ""
|
||||
for h in (_hashtag(t) for t in tags):
|
||||
if h and len(hashtags) + len(h) + 1 <= max(max_chars // 3, 1):
|
||||
hashtags = f"{hashtags} {h}".strip()
|
||||
tail = f"\n\n{permalink}" + (f"\n\n{hashtags}" if hashtags else "")
|
||||
body = (note.content if body is None else body).strip()
|
||||
if getattr(note, "title", None):
|
||||
body = f"{note.title}\n\n{article_teaser(note)}".strip()
|
||||
else:
|
||||
body = (note.content if body is None else body).strip()
|
||||
if getattr(note, "bookmark_of", None):
|
||||
# A bookmark leads with what it bookmarks (v2.9.0)
|
||||
body = f"🔖 {note.bookmark_of}\n\n{body}".strip()
|
||||
@@ -1215,7 +1230,10 @@ def _note_soup(markdown_text: str):
|
||||
import markdown
|
||||
from bs4 import BeautifulSoup
|
||||
|
||||
return BeautifulSoup(markdown.markdown(markdown_text, extensions=["fenced_code"]), "html.parser")
|
||||
from starpunk.markdown_ext import HashtagLineExtension
|
||||
|
||||
html = markdown.markdown(markdown_text, extensions=["fenced_code", HashtagLineExtension()])
|
||||
return BeautifulSoup(html, "html.parser")
|
||||
|
||||
|
||||
def _clean_url(url: str) -> str:
|
||||
@@ -1506,11 +1524,12 @@ def _reconcile(row, target: Target) -> tuple:
|
||||
site = current_app.config["SITE_URL"].rstrip("/")
|
||||
post = Post(
|
||||
note=note,
|
||||
permalink=f"{site}/note/{note.slug}",
|
||||
permalink=note.url,
|
||||
tags=[t["display_name"] for t in get_note_tags(note.id, entered_order=True)],
|
||||
max_chars=target.max_chars,
|
||||
# Articles are posted as a teaser without images (v2.16.0)
|
||||
media=_media_files(note.id, target.max_media, note.content)
|
||||
if note.kind == "note" else [],
|
||||
if note.kind == "note" and not note.title else [],
|
||||
kind=note.kind,
|
||||
target_url=note.reacts_to,
|
||||
target_title=_target_title(note.reacts_to),
|
||||
|
||||
@@ -480,6 +480,27 @@ def validate_note_path(file_path: Path, data_dir: Path) -> bool:
|
||||
# Atomic File Operations
|
||||
|
||||
|
||||
def find_trashed_file(data_dir: Path, file_path: str) -> Optional[Path]:
|
||||
"""
|
||||
Where delete_note_file put a note's file: .trash/<year>/<month>/<name>
|
||||
|
||||
Args:
|
||||
data_dir: Data directory
|
||||
file_path: The note's file_path as stored in the database
|
||||
|
||||
Returns:
|
||||
Path of the trashed file, or None if it can't be found
|
||||
"""
|
||||
parts = Path(file_path).parts
|
||||
name = Path(file_path).name
|
||||
candidates = []
|
||||
if "notes" in parts and len(parts) > parts.index("notes") + 2:
|
||||
i = parts.index("notes")
|
||||
candidates.append(data_dir / TRASH_DIR_NAME / parts[i + 1] / parts[i + 2] / name)
|
||||
candidates += sorted((data_dir / TRASH_DIR_NAME).glob(f"*/*/{name}"))
|
||||
return next((c for c in candidates if c.exists()), None)
|
||||
|
||||
|
||||
def write_note_file(file_path: Path, content: str) -> None:
|
||||
"""
|
||||
Write note content to file atomically
|
||||
@@ -695,6 +716,23 @@ def absolute_url_for(endpoint: str, **values) -> str:
|
||||
return current_app.config["SITE_URL"].rstrip("/") + url_for(endpoint, **values)
|
||||
|
||||
|
||||
def post_path(slug: str, title: Optional[str] = None) -> str:
|
||||
"""A post's URL path: /article/<slug> when it has a title, else /note/<slug> (v2.17.0)"""
|
||||
return f"/{'article' if title else 'note'}/{slug}"
|
||||
|
||||
|
||||
def post_url(slug: str, title: Optional[str] = None) -> str:
|
||||
"""
|
||||
A post's absolute URL (see post_path)
|
||||
|
||||
Built from SITE_URL without url_for, so it works outside a request:
|
||||
crossposting and backfeed run in background workers (v2.17.0).
|
||||
"""
|
||||
from flask import current_app
|
||||
|
||||
return current_app.config["SITE_URL"].rstrip("/") + post_path(slug, title)
|
||||
|
||||
|
||||
def iso_utc(value) -> str:
|
||||
"""
|
||||
Format a timestamp as RFC 3339 UTC for dt-* and Micropub (v2.8.0)
|
||||
|
||||
@@ -465,6 +465,13 @@ small { display: block; margin-top: var(--spacing-xs); color: var(--color-text-l
|
||||
.badge-like { background: #FECACA; color: #991B1B; }
|
||||
.badge-repost { background: #D1FAE5; color: #065F46; }
|
||||
.badge-bookmark { background: #FEF3C7; color: #92400E; }
|
||||
.badge-error { background: var(--color-error); color: #fff; }
|
||||
|
||||
/* Admin Log (v2.18.0) */
|
||||
.log-table td { vertical-align: top; }
|
||||
.log-table .button { white-space: nowrap; }
|
||||
.log-error code { white-space: pre-wrap; overflow-wrap: anywhere; font-size: 0.85rem; }
|
||||
.backfeed-status { margin-bottom: var(--spacing-lg); }
|
||||
.badge-mention { background: #E5E7EB; color: #374151; }
|
||||
|
||||
.status-badge {
|
||||
|
||||
@@ -8,7 +8,10 @@
|
||||
<nav class="admin-nav">
|
||||
<a href="{{ url_for('admin.dashboard') }}">Dashboard</a>
|
||||
<a href="{{ url_for('admin.new_note_form') }}">New Note</a>
|
||||
{% if config.WEBMENTION_ENABLED %}<a href="{{ url_for('admin.webmentions') }}">Webmentions</a>{% endif %}
|
||||
<a href="{{ url_for('admin.error_log') }}">Log{% if error_count %} <span class="badge badge-error">{{ error_count }}</span>{% endif %}</a>
|
||||
<a href="{{ url_for('admin.tokens') }}">Connected Apps</a>
|
||||
<a href="{{ url_for('admin.settings') }}">Settings</a>
|
||||
<form action="{{ url_for('auth.logout') }}" method="POST" class="logout-form"><input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
|
||||
<button type="submit" class="button button-secondary">Logout</button>
|
||||
</form>
|
||||
|
||||
@@ -51,7 +51,7 @@
|
||||
<tr>
|
||||
<td class="note-content-preview">
|
||||
<div class="note-excerpt">
|
||||
{{ note.content[:100] }}{% if note.content|length > 100 %}...{% endif %}
|
||||
{% if note.title %}<strong>{{ note.title }}</strong>{% else %}{{ note.content[:100] }}{% if note.content|length > 100 %}...{% endif %}{% endif %}
|
||||
</div>
|
||||
<small class="note-slug">{{ note.slug }}</small>
|
||||
</td>
|
||||
@@ -67,7 +67,7 @@
|
||||
</td>
|
||||
<td class="note-actions">
|
||||
{% if note.published %}
|
||||
<a href="{{ url_for('public.note', slug=note.slug) }}" class="button button-small" target="_blank">
|
||||
<a href="{{ note.url }}" class="button button-small" target="_blank">
|
||||
View
|
||||
</a>
|
||||
{% endif %}
|
||||
|
||||
@@ -11,6 +11,12 @@
|
||||
</p>
|
||||
|
||||
<form action="{{ url_for('admin.update_note_submit', note_id=note.id) }}" method="POST" class="note-form"><input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
|
||||
<div class="form-group">
|
||||
<label for="title">Title (optional)</label>
|
||||
<input type="text" id="title" name="title" value="{{ note.title or '' }}" maxlength="200"
|
||||
placeholder="Leave blank for a note; a title makes it an article">
|
||||
</div>
|
||||
|
||||
<div class="form-group">
|
||||
{% if note.reacts_to %}
|
||||
<p class="note-meta">{{ {'like': '★ Like of', 'repost': '🔁 Repost of', 'bookmark': '🔖 Bookmark of'}[note.kind] }} <a href="{{ note.reacts_to }}">{{ note.reacts_to }}</a></p>
|
||||
@@ -20,12 +26,18 @@
|
||||
id="content"
|
||||
name="content"
|
||||
rows="{{ 6 if note.reacts_to else 20 }}"
|
||||
{% if not note.reacts_to %}required{% endif %}
|
||||
autofocus
|
||||
>{{ note.content }}</textarea>
|
||||
<small>Use Markdown syntax for formatting</small>
|
||||
</div>
|
||||
|
||||
<div class="form-group">
|
||||
<label for="summary">Summary (optional)</label>
|
||||
<textarea id="summary" name="summary" rows="2"
|
||||
placeholder="A sentence or two for the homepage, feeds and crossposts">{{ note.summary or '' }}</textarea>
|
||||
<small>Articles only. Leave blank to use the start of the text.</small>
|
||||
</div>
|
||||
|
||||
<div class="form-group">
|
||||
<label for="slug">Slug (permanent)</label>
|
||||
<input type="text"
|
||||
|
||||
@@ -0,0 +1,57 @@
|
||||
{% extends "admin/base.html" %}
|
||||
|
||||
{% block title %}Log - StarPunk Admin{% endblock %}
|
||||
|
||||
{% block admin_content %}
|
||||
<div class="log-admin">
|
||||
<h2>Log</h2>
|
||||
<p class="text-muted">What is failing right now. An entry goes away once the next attempt succeeds.</p>
|
||||
|
||||
{% if entries %}
|
||||
<div class="table-scroll">
|
||||
<table class="note-table log-table">
|
||||
<thead>
|
||||
<tr>
|
||||
<th>When (UTC)</th>
|
||||
<th>What</th>
|
||||
<th>Post</th>
|
||||
<th>Error</th>
|
||||
<th></th>
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody>
|
||||
{% for e in entries %}
|
||||
<tr>
|
||||
<td class="note-date">{{ e.when or '' }}</td>
|
||||
<td>
|
||||
{{ e.area }}
|
||||
{% if e.detail %}<br><small class="note-slug">{% if e.detail.startswith('http') %}<a href="{{ e.detail.split(' ')[0] }}" target="_blank" rel="noopener">{{ e.detail|truncate(60) }}</a>{% else %}{{ e.detail|truncate(80) }}{% endif %}</small>{% endif %}
|
||||
</td>
|
||||
<td>
|
||||
{% if e.note %}
|
||||
<a href="{{ url_for('admin.edit_note_form', note_id=e.note.id) }}">{{ (e.note.title or e.note.content or e.note.slug)|truncate(60) }}</a>
|
||||
{% if e.note.published %}<br><small><a href="{{ e.note.url }}" target="_blank">View</a></small>{% endif %}
|
||||
{% else %}
|
||||
<span class="text-muted">Site-wide</span>
|
||||
{% endif %}
|
||||
</td>
|
||||
<td class="log-error"><code>{{ e.error }}</code></td>
|
||||
<td>
|
||||
{% if e.action %}
|
||||
<form method="POST" action="{{ url_for(e.action[0], syndication_id=e.action[1]) }}"><input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
|
||||
<button type="submit" class="button button-small">{{ e.action[2] }}</button>
|
||||
</form>
|
||||
{% endif %}
|
||||
</td>
|
||||
</tr>
|
||||
{% endfor %}
|
||||
</tbody>
|
||||
</table>
|
||||
</div>
|
||||
{% else %}
|
||||
<div class="empty-state">
|
||||
<p>No errors. Crossposts, response checks, webmentions, WebSub and notifications are all working.</p>
|
||||
</div>
|
||||
{% endif %}
|
||||
</div>
|
||||
{% endblock %}
|
||||
@@ -7,6 +7,12 @@
|
||||
<h2>Create New Note</h2>
|
||||
|
||||
<form action="{{ url_for('admin.create_note_submit') }}" method="POST" enctype="multipart/form-data" class="note-form"><input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
|
||||
<div class="form-group">
|
||||
<label for="title">Title (optional)</label>
|
||||
<input type="text" id="title" name="title" value="" maxlength="200"
|
||||
placeholder="Leave blank for a note; a title makes it an article">
|
||||
</div>
|
||||
|
||||
<div class="form-group">
|
||||
<label for="content">Content (Markdown)</label>
|
||||
<textarea
|
||||
@@ -14,12 +20,18 @@
|
||||
name="content"
|
||||
rows="20"
|
||||
placeholder="Write your note in markdown..."
|
||||
required
|
||||
autofocus
|
||||
></textarea>
|
||||
<small>Use Markdown syntax for formatting</small>
|
||||
</div>
|
||||
|
||||
<div class="form-group">
|
||||
<label for="summary">Summary (optional)</label>
|
||||
<textarea id="summary" name="summary" rows="2"
|
||||
placeholder="A sentence or two for the homepage, feeds and crossposts"></textarea>
|
||||
<small>Articles only. Leave blank to use the start of the text.</small>
|
||||
</div>
|
||||
|
||||
<div class="form-group">
|
||||
<label for="custom_slug">Custom Slug (optional)</label>
|
||||
<input type="text"
|
||||
|
||||
@@ -0,0 +1,23 @@
|
||||
{% extends "admin/base.html" %}
|
||||
|
||||
{% block title %}Settings - StarPunk Admin{% endblock %}
|
||||
|
||||
{% block admin_content %}
|
||||
<div class="settings-admin">
|
||||
<h2>Settings</h2>
|
||||
|
||||
{# Notifications (v2.14.0, ADR-074; moved here in v2.18.0) #}
|
||||
<section class="notify-status">
|
||||
<h3>Notifications</h3>
|
||||
{% if notify.enabled %}
|
||||
<p>Sending {{ notify.events|join(', ') }} to {{ notify.services|join(', ') }} at {{ notify.priority }} priority.</p>
|
||||
{% if notify.last_error %}<p class="flash flash-error">Last send failed: {{ notify.last_error }}</p>{% endif %}
|
||||
<form method="POST" action="{{ url_for('admin.notifications_test') }}"><input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
|
||||
<button type="submit" class="button">Send test notification</button>
|
||||
</form>
|
||||
{% else %}
|
||||
<p>Off. Set <code>NOTIFY_URLS</code> to one or more Apprise URLs to be notified of new responses.</p>
|
||||
{% endif %}
|
||||
</section>
|
||||
</div>
|
||||
{% endblock %}
|
||||
@@ -6,35 +6,10 @@
|
||||
<div class="webmentions-admin">
|
||||
<h2>Webmentions</h2>
|
||||
|
||||
<div class="dashboard-actions">
|
||||
<a href="{{ url_for('admin.dashboard') }}" class="button">
|
||||
Back to Dashboard
|
||||
</a>
|
||||
</div>
|
||||
|
||||
{# Notifications (v2.14.0, ADR-074) #}
|
||||
{% if notify %}
|
||||
<section class="notify-status">
|
||||
<h3>Notifications</h3>
|
||||
{% if notify.enabled %}
|
||||
<p>Sending {{ notify.events|join(', ') }} to {{ notify.services|join(', ') }} at {{ notify.priority }} priority.</p>
|
||||
{% if notify.last_error %}<p class="flash flash-error">Last send failed: {{ notify.last_error }}</p>{% endif %}
|
||||
<form method="POST" action="{{ url_for('admin.notifications_test') }}"><input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
|
||||
<button type="submit" class="button">Send test notification</button>
|
||||
</form>
|
||||
{% else %}
|
||||
<p>Off. Set <code>NOTIFY_URLS</code> to one or more Apprise URLs to be notified of new responses.</p>
|
||||
{% endif %}
|
||||
</section>
|
||||
{% endif %}
|
||||
|
||||
{# Backfeed (v2.13.0, ADR-073) #}
|
||||
{% if backfeed and backfeed.enabled %}
|
||||
<section class="backfeed-status">
|
||||
<h3>Backfeed</h3>
|
||||
{% for silo, message in backfeed.denied.items() %}
|
||||
<p class="flash flash-error">{{ silo }}: {{ message }}</p>
|
||||
{% endfor %}
|
||||
{% if backfeed.remaining %}
|
||||
<p>Backfill started {{ backfeed.started }} UTC: {{ backfeed.remaining }} crosspost(s) left to check.</p>
|
||||
{% elif backfeed.finished %}
|
||||
@@ -42,7 +17,7 @@
|
||||
{% else %}
|
||||
<p>No backfill has been run. It checks every crosspost once for responses, however old the note.</p>
|
||||
{% endif %}
|
||||
{% if backfeed.errors %}<p>{{ backfeed.errors }} crosspost(s) had an error at their last check (see each note's edit page).</p>{% endif %}
|
||||
{% if backfeed.errors or backfeed.denied %}<p><a href="{{ url_for('admin.error_log') }}">Response checks have errors: see the Log.</a></p>{% endif %}
|
||||
<form method="POST" action="{{ url_for('admin.backfeed_backfill') }}"><input type="hidden" name="csrf_token" value="{{ csrf_token() }}">
|
||||
<button type="submit" class="button"{% if backfeed.remaining %} disabled{% endif %}>Backfill responses</button>
|
||||
</form>
|
||||
|
||||
+9
-9
@@ -3,17 +3,17 @@
|
||||
{% from "partials/reaction.html" import reaction %}
|
||||
{% import "partials/responses.html" as responses with context %}
|
||||
|
||||
{% block title %}{% if note.has_title %}{{ note.title }}{% elif note.excerpt.strip() %}{{ note.excerpt|truncate(60) }}{% elif note.repost_of %}Repost{% elif note.like_of %}Like{% elif note.bookmark_of %}Bookmark{% elif note.in_reply_to %}Reply{% else %}Photo{% endif %} · {{ config.SITE_NAME }}{% endblock %}
|
||||
{% block title %}{% if note.title %}{{ note.title }}{% elif note.excerpt.strip() %}{{ note.excerpt|truncate(60) }}{% elif note.repost_of %}Repost{% elif note.like_of %}Like{% elif note.bookmark_of %}Bookmark{% elif note.in_reply_to %}Reply{% else %}Photo{% endif %} · {{ config.SITE_NAME }}{% endblock %}
|
||||
|
||||
{% block content %}
|
||||
<article class="h-entry">
|
||||
{# Notes starting with a '# Heading' have a title (Q22; Note.has_title) #}
|
||||
{% set has_explicit_title = note.has_title %}
|
||||
|
||||
{# p-name only if note has explicit title (per Q22) #}
|
||||
{% if has_explicit_title %}
|
||||
{# Titled notes are articles: p-name only then, so notes get no implied name (ADR-076) #}
|
||||
{% if note.title %}
|
||||
<h1 class="p-name">{{ note.title }}</h1>
|
||||
{% endif %}
|
||||
{% if note.summary %}
|
||||
<p class="p-summary">{{ note.summary }}</p>
|
||||
{% endif %}
|
||||
|
||||
{# Reply context (v1.6.0 Phase 4) - displayed if this is a reply post #}
|
||||
{% if note.in_reply_to %}
|
||||
@@ -49,12 +49,12 @@
|
||||
|
||||
{# e-content: note content BELOW media (per ADR-057) #}
|
||||
<div class="e-content">
|
||||
{{ note.body_html|safe }}
|
||||
{{ note.html|safe }}
|
||||
</div>
|
||||
|
||||
<footer class="note-meta">
|
||||
{# u-url and u-uid same for notes (per Q23) #}
|
||||
<a class="u-url u-uid" href="{{ absolute_url_for('public.note', slug=note.slug) }}"><time class="dt-published" datetime="{{ note.created_at|iso_utc }}">{{ note.created_at.strftime('%B %-d, %Y · %-I:%M %p') }}</time></a>
|
||||
<a class="u-url u-uid" href="{{ note.url }}"><time class="dt-published" datetime="{{ note.created_at|iso_utc }}">{{ note.created_at.strftime('%B %-d, %Y · %-I:%M %p') }}</time></a>
|
||||
{% if note.updated_at and note.updated_at != note.created_at %}
|
||||
<span class="updated">Updated <time class="dt-updated" datetime="{{ note.updated_at|iso_utc }}">{{ note.updated_at.strftime('%b %-d, %Y') }}</time></span>
|
||||
{% endif %}
|
||||
@@ -79,7 +79,7 @@
|
||||
</footer>
|
||||
|
||||
<div id="responses"></div>
|
||||
{{ responses.reactions(likes, reposts, replies, bookmarks, syndications, absolute_url_for('public.note', slug=note.slug), quotes) }}
|
||||
{{ responses.reactions(likes, reposts, replies, bookmarks, syndications, note.url, quotes) }}
|
||||
|
||||
<nav class="note-nav">
|
||||
<a href="/">← All notes</a>
|
||||
|
||||
@@ -4,10 +4,9 @@
|
||||
{% from "partials/responses.html" import list_counts %}
|
||||
{% macro note_preview(note, author) %}
|
||||
<article class="h-entry note-preview">
|
||||
{# Notes starting with a '# Heading' have a title (Q22; Note.has_title) #}
|
||||
{% set has_explicit_title = note.has_title %}
|
||||
{% if has_explicit_title %}
|
||||
<h2 class="p-name"><a href="{{ absolute_url_for('public.note', slug=note.slug) }}">{{ note.title }}</a></h2>
|
||||
{# Titled notes are articles (ADR-076) #}
|
||||
{% if note.title %}
|
||||
<h2 class="p-name"><a href="{{ note.url }}">{{ note.title }}</a></h2>
|
||||
{% endif %}
|
||||
|
||||
{% if note.in_reply_to %}
|
||||
@@ -16,15 +15,19 @@
|
||||
|
||||
{{ reaction(note) }}
|
||||
|
||||
{{ display_media(note.media, note.excerpt|truncate(150)) }}
|
||||
|
||||
{% if has_explicit_title %}
|
||||
{# Titled notes are articles: show a summary and link through #}
|
||||
{% if note.title %}
|
||||
{# Articles: title, summary and a link through; images stay on the article page (v2.16.0).
|
||||
The photos stay in the markup, unseen, so parsers read the same post type here as on the page. #}
|
||||
{% for item in note.media or [] %}<data class="u-photo" value="{{ url_for('public.media_file', path=item.path) }}"></data>{% endfor %}
|
||||
{% set summary = note.summary or note.excerpt %}
|
||||
{% if summary.strip() %}
|
||||
<div class="p-summary">
|
||||
<p>{{ note.excerpt }}</p>
|
||||
<p>{{ summary }}</p>
|
||||
</div>
|
||||
<p class="read-more"><a href="{{ absolute_url_for('public.note', slug=note.slug) }}">Read more →</a></p>
|
||||
{% endif %}
|
||||
<p class="read-more"><a href="{{ note.url }}">Read more →</a></p>
|
||||
{% else %}
|
||||
{{ display_media(note.media, note.excerpt|truncate(150)) }}
|
||||
{# Always present, even empty: without it a text-free photo post gets an implied name (mf2) #}
|
||||
<div class="e-content">
|
||||
{{ note.html|safe }}
|
||||
@@ -32,13 +35,13 @@
|
||||
{% endif %}
|
||||
|
||||
<footer class="note-meta">
|
||||
<a class="u-url u-uid" href="{{ absolute_url_for('public.note', slug=note.slug) }}"><time class="dt-published" datetime="{{ note.created_at|iso_utc }}">{{ note.created_at.strftime('%b %-d, %Y') }}</time></a>
|
||||
<a class="u-url u-uid" href="{{ note.url }}"><time class="dt-published" datetime="{{ note.created_at|iso_utc }}">{{ note.created_at.strftime('%b %-d, %Y') }}</time></a>
|
||||
{% if note.tags %}
|
||||
<span class="note-tags">
|
||||
{% for tag in note.tags %}<a class="p-category" rel="tag" href="{{ url_for('public.tag', tag=tag.name) }}">{{ tag.display_name }}</a>{% endfor %}
|
||||
</span>
|
||||
{% endif %}
|
||||
{{ list_counts(note.response_counts if note.response_counts is defined else None, absolute_url_for('public.note', slug=note.slug)) }}
|
||||
{{ list_counts(note.response_counts if note.response_counts is defined else None, note.url) }}
|
||||
{% if author %}
|
||||
{# Single-author site: keep the h-card for parsers, hide it from readers #}
|
||||
<span class="p-author h-card visually-hidden"><a class="p-name u-url" href="{{ author.url or author.me }}">{{ author.name or author.url or author.me }}</a></span>
|
||||
|
||||
@@ -0,0 +1,119 @@
|
||||
"""Admin Log and Settings pages (v2.18.0)"""
|
||||
|
||||
import pytest
|
||||
|
||||
from starpunk import backfeed, create_app, error_log
|
||||
from starpunk.auth import create_session
|
||||
from starpunk.database import get_db
|
||||
from starpunk.notes import create_note
|
||||
|
||||
SITE = "https://blog.example.com"
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def app(tmp_path):
|
||||
app = create_app({
|
||||
"TESTING": True, "SITE_URL": SITE, "ADMIN_ME": "https://example.com",
|
||||
"DATABASE_PATH": tmp_path / "starpunk.db", "DATA_PATH": tmp_path,
|
||||
"NOTES_PATH": tmp_path / "notes", "SESSION_SECRET": "test", "CSRF_ENABLED": False,
|
||||
"BACKGROUND_WORKERS_ENABLED": False, "WEBMENTION_ENABLED": True,
|
||||
})
|
||||
backfeed.denied.clear()
|
||||
yield app
|
||||
backfeed.denied.clear()
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def browser(app):
|
||||
with app.test_request_context():
|
||||
token = create_session("https://example.com")
|
||||
client = app.test_client()
|
||||
client.set_cookie("starpunk_session", token)
|
||||
return client
|
||||
|
||||
|
||||
def _failures(app):
|
||||
"""One of each kind of error, on two notes"""
|
||||
with app.app_context():
|
||||
broken = create_note(content="A crosspost that broke", published=True)
|
||||
reply = create_note(content="Replying", published=True)
|
||||
db = get_db(app)
|
||||
db.execute("UPDATE notes SET in_reply_to = 'https://gone.example/post' WHERE id = ?", (reply.id,))
|
||||
db.execute("INSERT INTO syndications (note_id, target, state, last_error, updated_at) "
|
||||
"VALUES (?, 'bluesky', 'failed', 'HTTP 400: post too long', '2026-11-12 10:00:00')",
|
||||
(broken.id,))
|
||||
db.execute("INSERT INTO syndications (note_id, target, state, remote_url, backfeed_error, "
|
||||
"backfeed_checked_at) VALUES (?, 'gotosocial', 'synced', 'https://social.example/1', "
|
||||
"'HTTP 404 from GoToSocial', '2026-11-12 11:00:00')", (broken.id,))
|
||||
db.execute("INSERT INTO webmention_queue (source_url, target_url, source_note_id, status, last_error) "
|
||||
"VALUES (?, 'https://other.example/a', ?, 'failed', 'Endpoint returned 500')",
|
||||
(f"{SITE}/note/{reply.slug}", reply.id))
|
||||
db.execute("INSERT INTO reply_contexts (url, fetch_status, fetch_error) "
|
||||
"VALUES ('https://gone.example/post', 'error', 'HTTP 410 Gone')")
|
||||
db.execute("INSERT INTO syndications (note_id, target, state, last_error) "
|
||||
"VALUES (?, 'threads', 'synced', 'old error, since fixed')", (reply.id,))
|
||||
db.commit()
|
||||
return broken, reply
|
||||
|
||||
|
||||
def test_log_lists_each_error_with_its_post(app, browser):
|
||||
broken, reply = _failures(app)
|
||||
backfeed.denied["threads"] = "Needs a Threads token with threads_manage_replies"
|
||||
|
||||
page = browser.get("/admin/log").get_data(as_text=True)
|
||||
for text in ("Crosspost to Bluesky", "HTTP 400: post too long", "Retry",
|
||||
"Response check on GoToSocial", "HTTP 404 from GoToSocial", "Check now",
|
||||
"Webmention sent", "https://other.example/a", "Endpoint returned 500",
|
||||
"Reply context fetch", "HTTP 410 Gone",
|
||||
"Response checks on Threads", "Needs a Threads token", "Site-wide"):
|
||||
assert text in page, text
|
||||
assert f"/admin/edit/{broken.id}" in page and f"/admin/edit/{reply.id}" in page
|
||||
assert "old error, since fixed" not in page, "synced crossposts aren't errors"
|
||||
assert 'class="badge badge-error">5<' in page
|
||||
|
||||
with app.app_context():
|
||||
assert error_log.count() == 5
|
||||
areas = [e["area"] for e in error_log.entries()]
|
||||
assert areas[0] == "Response checks on Threads", "site-wide problems first"
|
||||
assert areas.index("Response check on GoToSocial") < areas.index("Crosspost to Bluesky"), "newest first"
|
||||
|
||||
|
||||
def test_log_retry_clears_the_crosspost_error(app, browser):
|
||||
broken, _ = _failures(app)
|
||||
with app.app_context():
|
||||
sid = get_db(app).execute("SELECT id FROM syndications WHERE target = 'bluesky'").fetchone()[0]
|
||||
browser.post(f"/admin/syndication/{sid}/retry")
|
||||
assert "HTTP 400: post too long" not in browser.get("/admin/log").get_data(as_text=True)
|
||||
|
||||
|
||||
def test_empty_log_and_no_badge(browser):
|
||||
page = browser.get("/admin/log").get_data(as_text=True)
|
||||
assert "No errors." in page and "badge-error" not in page
|
||||
|
||||
|
||||
def test_notification_error_is_logged(app, browser):
|
||||
with app.app_context():
|
||||
get_db(app).execute("INSERT INTO site_state (key, value) VALUES "
|
||||
"('notify_last_error', '2026-11-12 09:00:00 UTC gotify: 401 Unauthorized')")
|
||||
get_db(app).commit()
|
||||
page = browser.get("/admin/log").get_data(as_text=True)
|
||||
assert "Notifications" in page and "gotify: 401 Unauthorized" in page and "2026-11-12 09:00:00" in page
|
||||
|
||||
|
||||
def test_webmentions_page_is_decluttered(browser):
|
||||
page = browser.get("/admin/webmentions").get_data(as_text=True)
|
||||
assert "Back to Dashboard" not in page
|
||||
assert "Send test notification" not in page and "<h3>Notifications</h3>" not in page
|
||||
|
||||
|
||||
def test_nav_and_settings_page(browser):
|
||||
page = browser.get("/admin/settings").get_data(as_text=True)
|
||||
assert "<h3>Notifications</h3>" in page and "NOTIFY_URLS" in page
|
||||
for link in ("/admin/webmentions", "/admin/log", "/admin/settings", "/admin/tokens"):
|
||||
assert f'href="{link}"' in page, link
|
||||
|
||||
|
||||
def test_pages_require_login(app):
|
||||
client = app.test_client()
|
||||
for path in ("/admin/log", "/admin/settings"):
|
||||
assert client.get(path).status_code == 302
|
||||
@@ -0,0 +1,275 @@
|
||||
"""
|
||||
Articles: titles and summaries stored apart from the text (v2.16.0, ADR-076).
|
||||
|
||||
Feeds give only articles a title and never repeat it in the content; the
|
||||
homepage and tag pages show an article as title, summary and "Read more"
|
||||
without its images; the admin editor has Title and Summary fields.
|
||||
"""
|
||||
|
||||
import json
|
||||
import xml.etree.ElementTree as ET
|
||||
|
||||
import httpx
|
||||
import mf2py
|
||||
|
||||
from starpunk.auth import create_session
|
||||
from starpunk.notes import create_note, get_note
|
||||
from tests.test_micropub_v240 import SITE, app, client, h, jpeg, source # noqa: F401
|
||||
from tests.test_micropub_v265 import upload
|
||||
|
||||
ATOM = {"a": "http://www.w3.org/2005/Atom"}
|
||||
|
||||
|
||||
def micropub(client, h, **props):
|
||||
response = client.post("/micropub", json={"type": ["h-entry"], "properties": props}, headers=h)
|
||||
assert response.status_code == 201, response.get_json()
|
||||
return response.headers["Location"]
|
||||
|
||||
|
||||
def make_both(app):
|
||||
with app.app_context():
|
||||
article = create_note(content="The **body**.", title="An Article", summary="The gist.",
|
||||
published=True, tags=["essay"])
|
||||
note = create_note(content="# Just a heading\n\nin a note", published=True, tags=["essay"])
|
||||
return article, note
|
||||
|
||||
|
||||
class TestFeeds:
|
||||
def test_rss_title_only_for_articles(self, app, client):
|
||||
article, note = make_both(app)
|
||||
items = {i.find("link").text: i for i in ET.fromstring(client.get("/feed.rss").data).iter("item")}
|
||||
a, n = items[f"{SITE}/article/{article.slug}"], items[f"{SITE}/note/{note.slug}"]
|
||||
assert a.find("title").text == "An Article"
|
||||
assert "An Article" not in a.find("description").text # not repeated in the body
|
||||
assert n.find("title") is None
|
||||
assert n.find("description") is not None
|
||||
|
||||
def test_atom_empty_title_and_summary(self, app, client):
|
||||
article, note = make_both(app)
|
||||
entries = {e.find("a:id", ATOM).text: e
|
||||
for e in ET.fromstring(client.get("/feed.atom").data).findall("a:entry", ATOM)}
|
||||
a, n = entries[f"{SITE}/article/{article.slug}"], entries[f"{SITE}/note/{note.slug}"]
|
||||
assert a.find("a:title", ATOM).text == "An Article"
|
||||
assert a.find("a:summary", ATOM).text == "The gist."
|
||||
assert "An Article" not in a.find("a:content", ATOM).text
|
||||
assert n.find("a:title", ATOM) is not None and not n.find("a:title", ATOM).text
|
||||
assert n.find("a:summary", ATOM) is None
|
||||
|
||||
def test_json_feed(self, app, client):
|
||||
article, note = make_both(app)
|
||||
items = {i["url"]: i for i in json.loads(client.get("/feed.json").data)["items"]}
|
||||
a, n = items[f"{SITE}/article/{article.slug}"], items[f"{SITE}/note/{note.slug}"]
|
||||
assert (a["title"], a["summary"]) == ("An Article", "The gist.")
|
||||
assert "An Article" not in a["content_html"]
|
||||
assert "title" not in n and "summary" not in n
|
||||
assert "<h1>Just a heading</h1>" in n["content_html"]
|
||||
|
||||
|
||||
class TestPages:
|
||||
def test_article_page(self, app, client):
|
||||
article, _ = make_both(app)
|
||||
(entry,) = [i for i in mf2py.parse(doc=client.get(f"/article/{article.slug}").data.decode(),
|
||||
url=f"{SITE}/article/{article.slug}")["items"]
|
||||
if "h-entry" in i["type"]]
|
||||
props = entry["properties"]
|
||||
assert props["name"] == ["An Article"]
|
||||
assert props["summary"] == ["The gist."]
|
||||
assert not props["content"][0]["value"].startswith("An Article")
|
||||
|
||||
def test_homepage_and_tag_page(self, app, client, h):
|
||||
photo = upload(client, h)
|
||||
url = micropub(client, h, name=["Trip"], content=["Day one of the trip."], photo=[photo],
|
||||
category=["essay"])
|
||||
micropub(client, h, content=["A photo note"], photo=[upload(client, h, "blue")], category=["essay"])
|
||||
with app.app_context():
|
||||
slug = url.rsplit("/", 1)[1]
|
||||
article = get_note(slug=slug)
|
||||
for path in ("/", "/tag/essay"):
|
||||
html = client.get(path).data.decode()
|
||||
start = html.index(f'href="{url}"')
|
||||
section = html[html.rindex("<article", 0, start):html.index("</article>", start)]
|
||||
assert "Trip" in section and "Day one of the trip." in section and "Read more" in section
|
||||
assert "<img" not in section and "e-content" not in section
|
||||
assert 'class="u-photo"' in section # parsers still see a photo post
|
||||
assert html.count("<img") >= 1 # the photo note still shows its image
|
||||
assert article.title == "Trip"
|
||||
|
||||
def test_preview_uses_summary_over_excerpt(self, app, client):
|
||||
make_both(app)
|
||||
html = client.get("/").data.decode()
|
||||
assert "The gist." in html and "The <strong>body</strong>." not in html
|
||||
|
||||
|
||||
class TestAdmin:
|
||||
def login(self, app, client):
|
||||
with app.test_request_context():
|
||||
client.set_cookie("starpunk_session", create_session(app.config["ADMIN_ME"]))
|
||||
|
||||
def test_create_and_edit_article(self, app, client):
|
||||
self.login(app, client)
|
||||
response = client.post("/admin/new", data={
|
||||
"title": "From the editor", "summary": "Short.", "content": "Body", "published": "on"})
|
||||
assert response.status_code == 302
|
||||
with app.app_context():
|
||||
from starpunk.notes import list_notes
|
||||
(note,) = list_notes()
|
||||
assert (note.title, note.summary, note.content) == ("From the editor", "Short.", "Body")
|
||||
|
||||
form = client.get(f"/admin/edit/{note.id}").data.decode()
|
||||
assert 'value="From the editor"' in form and ">Short.</textarea>" in form
|
||||
|
||||
client.post(f"/admin/edit/{note.id}", data={"title": "", "summary": "", "content": "Body",
|
||||
"published": "on"})
|
||||
with app.app_context():
|
||||
note = get_note(id=note.id)
|
||||
assert (note.title, note.summary) == (None, None)
|
||||
|
||||
def test_title_only_article(self, app, client):
|
||||
self.login(app, client)
|
||||
client.post("/admin/new", data={"title": "Only a title", "content": "", "published": "on"})
|
||||
with app.app_context():
|
||||
from starpunk.notes import list_notes
|
||||
(note,) = list_notes()
|
||||
assert note.title == "Only a title" and note.content == ""
|
||||
|
||||
|
||||
class TestInlineImages:
|
||||
"""Articles posted with images in their text (v2.16.0)"""
|
||||
|
||||
def remote_host(self, monkeypatch, ok=("/a.jpg",)):
|
||||
fetched = []
|
||||
|
||||
def serve(request): # the fetcher connects to the pinned address, so match on path
|
||||
fetched.append(request.url.path)
|
||||
if request.url.path in ok:
|
||||
return httpx.Response(200, content=jpeg("green"))
|
||||
return httpx.Response(404)
|
||||
|
||||
monkeypatch.setattr("starpunk.webmention_ssrf.TRANSPORT", httpx.MockTransport(serve))
|
||||
monkeypatch.setattr("starpunk.webmention_ssrf.socket.getaddrinfo",
|
||||
lambda *a, **k: [(2, 1, 6, "", ("93.184.216.34", 0))])
|
||||
return fetched
|
||||
|
||||
def test_html_is_kept_over_text_fallback(self, app, client, h, monkeypatch):
|
||||
self.remote_host(monkeypatch)
|
||||
html = '<p>Intro <a href="https://x.example">link</a></p><img src="https://cdn.example/a.jpg" alt="A">'
|
||||
url = micropub(client, h, name=["T"], content=[{"html": html, "text": "Intro link"}])
|
||||
(content,) = source(client, h, url)["properties"]["content"]
|
||||
assert "html" in content and 'href="https://x.example"' in content["html"]
|
||||
assert "<img" in content["html"]
|
||||
|
||||
def test_remote_images_are_copied(self, app, client, h, monkeypatch):
|
||||
fetched = self.remote_host(monkeypatch)
|
||||
url = micropub(client, h, name=["T"], content=[
|
||||
"Intro\n\n\n\n\n\n"
|
||||
"Again "])
|
||||
with app.app_context():
|
||||
note = get_note(slug=url.rsplit("/", 1)[1])
|
||||
assert fetched.count("/a.jpg") == 1 # each image once
|
||||
assert "https://cdn.example/a.jpg" not in note.content
|
||||
assert note.content.count(f"]({SITE}/media/") == 2
|
||||
assert "https://cdn.example/gone.jpg" in note.content # couldn't fetch: left as is
|
||||
assert client.get(note.content.split(f"]({SITE}")[1].split(")")[0]).status_code == 200
|
||||
|
||||
def test_html_images_copied_and_rendered_cleanly(self, app, client, h, monkeypatch):
|
||||
self.remote_host(monkeypatch)
|
||||
url = micropub(client, h, name=["T"], content=[{"html":
|
||||
'<p>Intro</p><img src="https://cdn.example/a.jpg" alt="A"><p>More</p><script>x()</script>'}])
|
||||
with app.app_context():
|
||||
note = get_note(slug=url.rsplit("/", 1)[1])
|
||||
assert note.content_format == "html"
|
||||
assert note.html.startswith("<p>Intro</p><img") and f'src="{SITE}/media/' in note.html
|
||||
assert "<br" not in note.html and "<p></p>" not in note.html and "script" not in note.html
|
||||
|
||||
def test_own_images_not_fetched(self, app, client, h, monkeypatch):
|
||||
fetched = self.remote_host(monkeypatch)
|
||||
micropub(client, h, content=[f""])
|
||||
assert fetched == []
|
||||
|
||||
def test_update_copies_new_images(self, app, client, h, monkeypatch):
|
||||
self.remote_host(monkeypatch)
|
||||
url = micropub(client, h, name=["T"], content=["Before"])
|
||||
client.post("/micropub", json={"action": "update", "url": url,
|
||||
"replace": {"content": [""]}}, headers=h)
|
||||
with app.app_context():
|
||||
assert f"]({SITE}/media/" in get_note(slug=url.rsplit("/", 1)[1]).content
|
||||
|
||||
|
||||
class TestArticleUrls:
|
||||
"""Articles live at /article/<title-slug>, notes at /note/<slug> (v2.17.0)"""
|
||||
|
||||
def test_micropub_article_gets_article_url_from_title(self, app, client, h):
|
||||
url = micropub(client, h, name=["Why I Left Twitter!"], content=["Long story."])
|
||||
assert url == f"{SITE}/article/why-i-left-twitter"
|
||||
assert source(client, h, url)["properties"]["url"] == [url]
|
||||
assert client.get("/article/why-i-left-twitter").status_code == 200
|
||||
|
||||
def test_note_keeps_note_url_and_timestamp_slug(self, app, client, h):
|
||||
url = micropub(client, h, content=["Just a note"])
|
||||
assert url.startswith(f"{SITE}/note/") and url.rsplit("/", 1)[1][:8].isdigit()
|
||||
|
||||
def test_wrong_prefix_redirects(self, app, client, h):
|
||||
article = micropub(client, h, name=["Moved"], content=["Body"])
|
||||
note = micropub(client, h, content=["Plain"])
|
||||
slug, note_slug = article.rsplit("/", 1)[1], note.rsplit("/", 1)[1]
|
||||
response = client.get(f"/note/{slug}")
|
||||
assert (response.status_code, response.location) == (301, f"/article/{slug}")
|
||||
response = client.get(f"/article/{note_slug}")
|
||||
assert (response.status_code, response.location) == (301, f"/note/{note_slug}")
|
||||
assert client.get("/article/no-such-post").status_code == 404
|
||||
|
||||
def test_micropub_accepts_either_url(self, app, client, h):
|
||||
url = micropub(client, h, name=["Either"], content=["Body"])
|
||||
old_style = url.replace("/article/", "/note/")
|
||||
response = client.post("/micropub", json={"action": "update", "url": old_style,
|
||||
"replace": {"summary": ["S"]}}, headers=h)
|
||||
assert response.status_code == 204
|
||||
assert source(client, h, url)["properties"]["summary"] == ["S"]
|
||||
|
||||
def test_title_slugs(self, app):
|
||||
with app.test_request_context():
|
||||
def slug(title, **kw):
|
||||
return create_note(content="Body", title=title, published=True, **kw).slug
|
||||
|
||||
assert slug("Café Culture") == "cafe-culture"
|
||||
assert slug("Café Culture") == "cafe-culture-2"
|
||||
assert slug("Search") == "search-article" # reserved
|
||||
assert slug("Mine", custom_slug="chosen") == "chosen" # mp-slug wins
|
||||
assert slug("🎉🎉").isdigit() # nothing usable: timestamp
|
||||
long = slug("word " * 40)
|
||||
assert len(long) <= 80 and long.endswith("word") and "--" not in long
|
||||
|
||||
def test_update_that_adds_or_removes_title_returns_new_url(self, app, client, h):
|
||||
note = micropub(client, h, content=["Starts as a note"])
|
||||
slug = note.rsplit("/", 1)[1]
|
||||
response = client.post("/micropub", json={"action": "update", "url": note,
|
||||
"replace": {"name": ["Now an Article"]}}, headers=h)
|
||||
assert (response.status_code, response.headers["Location"]) == (201, f"{SITE}/article/{slug}")
|
||||
response = client.post("/micropub", json={"action": "update", "url": f"{SITE}/article/{slug}",
|
||||
"replace": {"content": ["Edited"]}}, headers=h)
|
||||
assert response.status_code == 204 # URL unchanged
|
||||
response = client.post("/micropub", json={"action": "update", "url": f"{SITE}/article/{slug}",
|
||||
"delete": ["name"]}, headers=h)
|
||||
assert (response.status_code, response.headers["Location"]) == (201, f"{SITE}/note/{slug}")
|
||||
|
||||
def test_deleted_article_is_gone(self, app, client, h):
|
||||
url = micropub(client, h, name=["Short-lived"], content=["Body"])
|
||||
assert client.post("/micropub", data={"action": "delete", "url": url}, headers=h).status_code == 204
|
||||
assert client.get("/article/short-lived").status_code == 410
|
||||
|
||||
def test_webmention_target_and_links(self, app, client):
|
||||
article, note = make_both(app)
|
||||
from starpunk.routes.webmention import resolve_target_note
|
||||
with app.test_request_context():
|
||||
assert resolve_target_note(f"{SITE}/article/{article.slug}") == article.id
|
||||
assert resolve_target_note(f"{SITE}/note/{article.slug}") == article.id
|
||||
assert resolve_target_note(f"{SITE}/article/{article.slug}/x") is None
|
||||
html = client.get("/").data.decode()
|
||||
assert f'href="{SITE}/article/{article.slug}"' in html
|
||||
assert f'href="{SITE}/note/{note.slug}"' in html
|
||||
assert f"/note/{article.slug}" not in html
|
||||
|
||||
def test_search_links_to_article(self, app, client):
|
||||
article, _ = make_both(app)
|
||||
results = client.get("/api/search?q=body").get_json()["results"]
|
||||
assert [r["url"] for r in results if r["slug"] == article.slug] == [f"/article/{article.slug}"]
|
||||
@@ -543,7 +543,8 @@ def test_admin_backfill_and_check_now(app, client):
|
||||
assert s["backfeed_next_at"]
|
||||
|
||||
backfeed.denied["gotosocial"] = "Needs a GoToSocial token with read:statuses"
|
||||
assert "Needs a GoToSocial token" in browser.get("/admin/webmentions?origin=gotosocial").get_data(as_text=True)
|
||||
assert "Needs a GoToSocial token" in browser.get("/admin/log").get_data(as_text=True)
|
||||
assert "Response checks have errors" in browser.get("/admin/webmentions").get_data(as_text=True)
|
||||
|
||||
|
||||
def test_threads_avatar_kept_while_its_copy_exists(app, client, web):
|
||||
|
||||
+15
-29
@@ -55,7 +55,8 @@ def sample_notes(app):
|
||||
notes = []
|
||||
for i in range(5):
|
||||
note = create_note(
|
||||
content=f"# Test Note {i}\n\nThis is test content for note {i}.",
|
||||
content=f"This is test content for note {i}.",
|
||||
title=f"Test Note {i}",
|
||||
published=True,
|
||||
)
|
||||
notes.append(note)
|
||||
@@ -141,7 +142,8 @@ class TestGenerateFeed:
|
||||
import time
|
||||
for i in range(3):
|
||||
create_note(
|
||||
content=f"# Note {i}\n\nContent {i}.",
|
||||
content=f"Content {i}.",
|
||||
title=f"Note {i}",
|
||||
published=True,
|
||||
)
|
||||
time.sleep(0.01) # Ensure distinct timestamps
|
||||
@@ -342,41 +344,25 @@ class TestFormatRFC822Date:
|
||||
class TestGetNoteTitle:
|
||||
"""Test get_note_title() function"""
|
||||
|
||||
def test_get_note_title_with_heading(self, app):
|
||||
"""Test title extraction from note with heading"""
|
||||
def test_get_note_title_article(self, app):
|
||||
"""An article's item title is its title"""
|
||||
with app.app_context():
|
||||
note = create_note(content="# My First Note\n\nContent here.", published=True)
|
||||
title = get_note_title(note)
|
||||
assert title == "My First Note"
|
||||
note = create_note(content="Content here.", title="My First Note", published=True)
|
||||
assert get_note_title(note) == "My First Note"
|
||||
|
||||
def test_get_note_title_without_heading(self, app):
|
||||
"""Test title extraction from note without heading"""
|
||||
def test_get_note_title_untitled_note(self, app):
|
||||
"""Untitled notes have no item title (v2.16.0, ADR-076)"""
|
||||
with app.app_context():
|
||||
note = create_note(content="Just some content without heading.", published=True)
|
||||
title = get_note_title(note)
|
||||
|
||||
# Should use first line (Note.title handles this)
|
||||
assert len(title) > 0
|
||||
assert "Just some content" in title
|
||||
assert get_note_title(note) is None
|
||||
note = create_note(content="# A heading in the body\n\nis not a title", published=True)
|
||||
assert get_note_title(note) is None
|
||||
|
||||
def test_get_note_title_truncates_long_titles(self, app):
|
||||
"""Test title truncation for long titles"""
|
||||
with app.app_context():
|
||||
long_title = "A" * 150
|
||||
note = create_note(content=f"# {long_title}\n\nContent.", published=True)
|
||||
title = get_note_title(note)
|
||||
|
||||
# Should truncate to reasonable length
|
||||
assert len(title) <= 103 # 100 chars + "..."
|
||||
|
||||
def test_get_note_title_minimal_content(self, app):
|
||||
"""Test title extraction with minimal content"""
|
||||
with app.app_context():
|
||||
note = create_note(content="x", published=True)
|
||||
title = get_note_title(note)
|
||||
|
||||
# Should extract something (single character or slug)
|
||||
assert len(title) > 0
|
||||
note = create_note(content="Content.", title="A" * 150, published=True)
|
||||
assert len(get_note_title(note)) <= 103 # 100 chars + "..."
|
||||
|
||||
|
||||
class TestCleanHTMLForRSS:
|
||||
|
||||
@@ -49,7 +49,7 @@ def sample_notes(app):
|
||||
notes = []
|
||||
for i in range(5):
|
||||
note = create_note(
|
||||
content=f"# Test Note {i}\n\nThis is test content for note {i}.",
|
||||
title=f"Test Note {i}", content=f"This is test content for note {i}.",
|
||||
published=True,
|
||||
)
|
||||
notes.append(note)
|
||||
@@ -138,7 +138,7 @@ class TestGenerateAtom:
|
||||
# Create notes with distinct timestamps
|
||||
for i in range(3):
|
||||
create_note(
|
||||
content=f"# Note {i}\n\nContent {i}.",
|
||||
title=f"Note {i}", content=f"Content {i}.",
|
||||
published=True,
|
||||
)
|
||||
time.sleep(0.01)
|
||||
@@ -216,7 +216,7 @@ class TestGenerateAtom:
|
||||
"""Test ATOM feed includes HTML content properly escaped"""
|
||||
with app.app_context():
|
||||
note = create_note(
|
||||
content="# Test\n\nThis is **bold** and *italic*.",
|
||||
title="Test", content="This is **bold** and *italic*.",
|
||||
published=True,
|
||||
)
|
||||
|
||||
@@ -243,7 +243,7 @@ class TestGenerateAtom:
|
||||
"""Test ATOM feed escapes special XML characters"""
|
||||
with app.app_context():
|
||||
note = create_note(
|
||||
content="# Test & Special <Characters>\n\nContent with 'quotes' and \"doubles\".",
|
||||
title="Test & Special <Characters>", content="Content with 'quotes' and \"doubles\".",
|
||||
published=True,
|
||||
)
|
||||
|
||||
|
||||
@@ -49,7 +49,7 @@ def sample_notes(app):
|
||||
notes = []
|
||||
for i in range(5):
|
||||
note = create_note(
|
||||
content=f"# Test Note {i}\n\nThis is test content for note {i}.",
|
||||
title=f"Test Note {i}", content=f"This is test content for note {i}.",
|
||||
published=True,
|
||||
)
|
||||
notes.append(note)
|
||||
@@ -121,7 +121,7 @@ class TestGenerateJsonFeed:
|
||||
# Create notes with distinct timestamps
|
||||
for i in range(3):
|
||||
create_note(
|
||||
content=f"# Note {i}\n\nContent {i}.",
|
||||
title=f"Note {i}", content=f"Content {i}.",
|
||||
published=True,
|
||||
)
|
||||
time.sleep(0.01)
|
||||
@@ -195,7 +195,7 @@ class TestGenerateJsonFeed:
|
||||
"""Test JSON Feed includes HTML content"""
|
||||
with app.app_context():
|
||||
note = create_note(
|
||||
content="# Test\n\nThis is **bold** and *italic*.",
|
||||
title="Test", content="This is **bold** and *italic*.",
|
||||
published=True,
|
||||
)
|
||||
|
||||
|
||||
@@ -81,7 +81,7 @@ def note_with_single_media(app):
|
||||
with app.app_context():
|
||||
# Create note
|
||||
note = create_note(
|
||||
content="# Test Note\n\nNote with one image.",
|
||||
title="Test Note", content="Note with one image.",
|
||||
published=True
|
||||
)
|
||||
|
||||
@@ -106,7 +106,7 @@ def note_with_multiple_media(app):
|
||||
with app.app_context():
|
||||
# Create note
|
||||
note = create_note(
|
||||
content="# Gallery Note\n\nNote with three images.",
|
||||
title="Gallery Note", content="Note with three images.",
|
||||
published=True
|
||||
)
|
||||
|
||||
@@ -135,7 +135,7 @@ def note_without_media(app):
|
||||
"""Create note without media"""
|
||||
with app.app_context():
|
||||
note = create_note(
|
||||
content="# Plain Note\n\nNote without images.",
|
||||
title="Plain Note", content="Note without images.",
|
||||
published=True
|
||||
)
|
||||
notes = list_notes(published_only=True, limit=1)
|
||||
|
||||
@@ -57,20 +57,21 @@ class TestNoteHEntry:
|
||||
assert props['url'][0] == props['uid'][0], "u-url and u-uid should match"
|
||||
|
||||
def test_hentry_pname_only_with_explicit_title(self, client, app, data_dir):
|
||||
"""p-name only present when note has explicit title (per Q22)"""
|
||||
"""p-name only present when note has a title (ADR-076, was Q22)"""
|
||||
from starpunk.notes import create_note
|
||||
|
||||
# Create note WITH heading (explicit title)
|
||||
# Create note WITH a title (an article)
|
||||
with app.app_context():
|
||||
note_with_title = create_note(
|
||||
content="# Explicit Title\n\nThis note has a heading.",
|
||||
content="This note has a title.",
|
||||
title="Explicit Title",
|
||||
custom_slug="note-with-title",
|
||||
published=True
|
||||
)
|
||||
|
||||
response = client.get('/note/note-with-title')
|
||||
response = client.get('/article/note-with-title')
|
||||
assert response.status_code == 200, f"Failed to get note: {response.status_code}"
|
||||
parsed = mf2py.parse(doc=response.data.decode(), url='http://localhost/note/note-with-title')
|
||||
parsed = mf2py.parse(doc=response.data.decode(), url='http://localhost/article/note-with-title')
|
||||
|
||||
entries = [item for item in parsed['items'] if 'h-entry' in item.get('type', [])]
|
||||
assert len(entries) > 0, "No h-entry found in parsed HTML"
|
||||
|
||||
@@ -142,7 +142,8 @@ def test_split_title(content, title):
|
||||
@pytest.mark.parametrize("content,kind", [
|
||||
("#indieweb is great, posting from my phone", "note"),
|
||||
("#\n\nbody text", "note"),
|
||||
("# A Title\n\nThe body", "article"),
|
||||
# A heading in the text is no longer a title (v2.16.0, ADR-076)
|
||||
("# A Title\n\nThe body", "note"),
|
||||
])
|
||||
def test_post_type_of_hash_notes(app, client, content, kind):
|
||||
note = make_note(app, content)
|
||||
|
||||
@@ -167,11 +167,11 @@ def test_micropub_create_with_name(client, app, mock_valid_token):
|
||||
assert response.status_code == 201
|
||||
assert 'Location' in response.headers
|
||||
|
||||
# StarPunk titles are a '# Heading' first line, so name must land there
|
||||
# name is stored as the title, apart from the content (v2.16.0, ADR-076)
|
||||
slug = response.headers['Location'].rstrip('/').split('/')[-1]
|
||||
with app.app_context():
|
||||
note = get_note(slug)
|
||||
assert note.content == '# My Test Title\n\nContent goes here'
|
||||
assert note.content == 'Content goes here'
|
||||
assert note.title == 'My Test Title'
|
||||
|
||||
|
||||
@@ -193,7 +193,8 @@ def test_micropub_create_with_name_already_heading(client, app, mock_valid_token
|
||||
assert response.status_code == 201
|
||||
slug = response.headers['Location'].rstrip('/').split('/')[-1]
|
||||
with app.app_context():
|
||||
assert get_note(slug).content == '# Same Title\n\nBody'
|
||||
note = get_note(slug)
|
||||
assert (note.title, note.content) == ('Same Title', 'Body')
|
||||
|
||||
|
||||
def test_micropub_create_with_categories(client, app, mock_valid_token):
|
||||
|
||||
@@ -114,9 +114,29 @@ class TestUpdate:
|
||||
def test_replace_and_delete_name(self, app, client, h):
|
||||
url = create(client, h)
|
||||
self.update(client, h, url, replace={"name": ["Added"]})
|
||||
assert note_at(app, url).content.startswith("# Added")
|
||||
note = note_at(app, url)
|
||||
assert note.title == "Added" and not note.content.startswith("#")
|
||||
self.update(client, h, url, delete=["name"])
|
||||
assert "name" not in source(client, h, url)["properties"]
|
||||
assert note_at(app, url).title is None
|
||||
|
||||
def test_summary(self, app, client, h):
|
||||
"""summary is stored alongside content, updatable and returned by q=source (v2.16.0)"""
|
||||
url = create(client, h, name=["Title"], summary=["Short version"])
|
||||
props = source(client, h, url)["properties"]
|
||||
assert props["summary"] == ["Short version"] and props["name"] == ["Title"]
|
||||
assert self.update(client, h, url, replace={"summary": ["Shorter"]}).status_code == 204
|
||||
assert note_at(app, url).summary == "Shorter"
|
||||
assert self.update(client, h, url, delete=["summary"]).status_code == 204
|
||||
assert "summary" not in source(client, h, url)["properties"]
|
||||
|
||||
def test_article_body_may_go(self, app, client, h):
|
||||
"""A titled post may have no text, like a photo post (v2.16.0)"""
|
||||
url = create(client, h, name=["Only a title"])
|
||||
assert self.update(client, h, url, delete=["content"]).status_code == 204
|
||||
assert note_at(app, url).content == ""
|
||||
url = create(client, h)
|
||||
assert self.update(client, h, url, delete=["content"]).status_code == 400
|
||||
|
||||
def test_categories(self, app, client, h):
|
||||
url = create(client, h, category=["one", "two"])
|
||||
|
||||
@@ -0,0 +1,127 @@
|
||||
"""
|
||||
Migration 023 moves '# Heading' titles out of note files into notes.title (v2.16.0, ADR-076).
|
||||
|
||||
Starts from a fully migrated database, takes it back to before 023, then
|
||||
runs the migrations again with the data directory.
|
||||
"""
|
||||
|
||||
import sqlite3
|
||||
|
||||
import pytest
|
||||
|
||||
from starpunk import create_app
|
||||
from starpunk.migrations import MigrationError, run_migrations
|
||||
from starpunk.utils import calculate_content_hash
|
||||
|
||||
MIGRATION = "023_note_titles.sql"
|
||||
TITLED = "# Old Title\n\nThe body."
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def setup(tmp_path):
|
||||
data = tmp_path / "data"
|
||||
data.mkdir()
|
||||
db_path = data / "starpunk.db"
|
||||
create_app(config={"TESTING": True, "DATABASE_PATH": db_path, "DATA_PATH": data,
|
||||
"SESSION_SECRET": "x", "ADMIN_ME": "https://example.com",
|
||||
"SITE_URL": "https://blog.example.com"})
|
||||
|
||||
files = {
|
||||
"titled": ("notes/2026/11/titled.md", TITLED, None),
|
||||
"untitled": ("notes/2026/11/untitled.md", "#indieweb is great", None),
|
||||
"trashed": ("notes/2026/10/trashed.md", "# Gone\n\nBin.", "2026-11-01"),
|
||||
}
|
||||
conn = sqlite3.connect(db_path)
|
||||
for slug, (rel, text, deleted_at) in files.items():
|
||||
path = data / rel
|
||||
if deleted_at: # delete_note_file put it in .trash/<year>/<month>/
|
||||
path = data / ".trash" / "2026" / "10" / "trashed.md"
|
||||
path.parent.mkdir(parents=True, exist_ok=True)
|
||||
path.write_text(text)
|
||||
conn.execute(
|
||||
"INSERT INTO notes (slug, file_path, published, created_at, updated_at, deleted_at,"
|
||||
" content_hash) VALUES (?, ?, 1, '2026-11-01', '2026-11-01', ?, ?)",
|
||||
(slug, rel, deleted_at, calculate_content_hash(text)),
|
||||
)
|
||||
conn.execute("INSERT INTO notes_fts (rowid, slug, title, content) VALUES (1, 'titled', 'x', 'y')")
|
||||
# Back to before migration 023
|
||||
conn.execute("ALTER TABLE notes DROP COLUMN title")
|
||||
conn.execute("ALTER TABLE notes DROP COLUMN summary")
|
||||
conn.execute("DELETE FROM schema_migrations WHERE migration_name = ?", (MIGRATION,))
|
||||
conn.commit()
|
||||
conn.close()
|
||||
return db_path, data
|
||||
|
||||
|
||||
def notes(db_path):
|
||||
conn = sqlite3.connect(db_path)
|
||||
conn.row_factory = sqlite3.Row
|
||||
rows = {r["slug"]: dict(r) for r in conn.execute("SELECT * FROM notes")}
|
||||
conn.close()
|
||||
return rows
|
||||
|
||||
|
||||
def test_titles_move_out_of_files(setup):
|
||||
db_path, data = setup
|
||||
run_migrations(db_path, data_dir=data)
|
||||
|
||||
rows = notes(db_path)
|
||||
assert rows["titled"]["title"] == "Old Title"
|
||||
assert (data / "notes/2026/11/titled.md").read_text() == "The body."
|
||||
assert rows["titled"]["content_hash"] == calculate_content_hash("The body.")
|
||||
|
||||
assert rows["untitled"]["title"] is None # a hashtag isn't a heading
|
||||
assert (data / "notes/2026/11/untitled.md").read_text() == "#indieweb is great"
|
||||
|
||||
assert rows["trashed"]["title"] == "Gone" # found in .trash, so undelete still works
|
||||
assert (data / ".trash/2026/10/trashed.md").read_text() == "Bin."
|
||||
|
||||
conn = sqlite3.connect(db_path)
|
||||
assert conn.execute("SELECT COUNT(*) FROM notes_fts").fetchone()[0] == 0 # rebuilt at startup
|
||||
assert conn.execute("SELECT 1 FROM schema_migrations WHERE migration_name = ?",
|
||||
(MIGRATION,)).fetchone()
|
||||
conn.close()
|
||||
|
||||
|
||||
def test_runs_once(setup):
|
||||
"""Afterwards a heading in a note's text is just a heading"""
|
||||
db_path, data = setup
|
||||
run_migrations(db_path, data_dir=data)
|
||||
(data / "notes/2026/11/untitled.md").write_text("# Now a heading\n\nNew text")
|
||||
run_migrations(db_path, data_dir=data)
|
||||
assert notes(db_path)["untitled"]["title"] is None
|
||||
assert (data / "notes/2026/11/untitled.md").read_text() == "# Now a heading\n\nNew text"
|
||||
|
||||
|
||||
def test_failure_puts_files_back(setup, monkeypatch):
|
||||
db_path, data = setup
|
||||
import starpunk.utils as utils
|
||||
|
||||
real_write = utils.write_note_file
|
||||
written = []
|
||||
|
||||
def write_then_fail(path, content):
|
||||
if written:
|
||||
raise OSError("disk full")
|
||||
written.append(path)
|
||||
real_write(path, content)
|
||||
|
||||
monkeypatch.setattr(utils, "write_note_file", write_then_fail)
|
||||
with pytest.raises(MigrationError):
|
||||
run_migrations(db_path, data_dir=data)
|
||||
|
||||
assert written # one file was changed before the failure...
|
||||
assert (data / "notes/2026/11/titled.md").read_text() == TITLED # ...and put back
|
||||
assert (data / ".trash/2026/10/trashed.md").read_text() == "# Gone\n\nBin."
|
||||
conn = sqlite3.connect(db_path)
|
||||
assert not conn.execute("SELECT 1 FROM schema_migrations WHERE migration_name = ?",
|
||||
(MIGRATION,)).fetchone()
|
||||
assert "title" not in [r[1] for r in conn.execute("PRAGMA table_info(notes)")]
|
||||
conn.close()
|
||||
|
||||
|
||||
def test_without_data_dir_only_schema(setup):
|
||||
db_path, data = setup
|
||||
run_migrations(db_path)
|
||||
assert notes(db_path)["titled"]["title"] is None
|
||||
assert (data / "notes/2026/11/titled.md").read_text() == TITLED
|
||||
+34
-48
@@ -11,6 +11,7 @@ Organized by model:
|
||||
import pytest
|
||||
from datetime import datetime, timedelta, timezone
|
||||
from pathlib import Path
|
||||
from dataclasses import replace
|
||||
from starpunk.models import Note, Session, Token, AuthState, split_title
|
||||
from starpunk.utils import calculate_content_hash
|
||||
|
||||
@@ -139,13 +140,12 @@ class TestNoteModel:
|
||||
html2 = note.html
|
||||
assert html1 == html2
|
||||
|
||||
def test_title_extraction_from_heading(self, tmp_path):
|
||||
"""Test title extraction from markdown heading"""
|
||||
def test_title_is_the_column_not_the_content(self, tmp_path):
|
||||
"""A title comes from notes.title; a heading in the content is just a heading (ADR-076)"""
|
||||
note_file = tmp_path / "notes" / "2024" / "11" / "test.md"
|
||||
note_file.parent.mkdir(parents=True)
|
||||
note_file.write_text("# My Note Title\n\nContent.")
|
||||
|
||||
note = Note(
|
||||
note_file.write_text("# A Heading\n\nContent.")
|
||||
kwargs = dict(
|
||||
id=1,
|
||||
slug="test",
|
||||
file_path="notes/2024/11/test.md",
|
||||
@@ -154,29 +154,13 @@ class TestNoteModel:
|
||||
updated_at=datetime.now(timezone.utc).replace(tzinfo=None),
|
||||
_data_dir=tmp_path,
|
||||
)
|
||||
assert Note(**kwargs).title is None
|
||||
assert "<h1>A Heading</h1>" in Note(**kwargs).html
|
||||
assert Note(**kwargs, title="My Note Title").title == "My Note Title"
|
||||
|
||||
assert note.title == "My Note Title"
|
||||
|
||||
def test_title_extraction_from_first_line(self, tmp_path):
|
||||
"""Test title extraction from first line without heading"""
|
||||
note_file = tmp_path / "notes" / "2024" / "11" / "test.md"
|
||||
note_file.parent.mkdir(parents=True)
|
||||
note_file.write_text("Just a note without heading\n\nMore content.")
|
||||
|
||||
note = Note(
|
||||
id=1,
|
||||
slug="test",
|
||||
file_path="notes/2024/11/test.md",
|
||||
published=True,
|
||||
created_at=datetime.now(timezone.utc).replace(tzinfo=None),
|
||||
updated_at=datetime.now(timezone.utc).replace(tzinfo=None),
|
||||
_data_dir=tmp_path,
|
||||
)
|
||||
|
||||
assert note.title == "Just a note without heading"
|
||||
|
||||
def test_title_fallback_to_slug(self):
|
||||
"""Test title falls back to slug if no content"""
|
||||
def test_label(self, tmp_path):
|
||||
"""label: title, else excerpt, else slug"""
|
||||
assert self._note_with(tmp_path, "Just a note\n\nMore.").label == "Just a note More."
|
||||
note = Note(
|
||||
id=1,
|
||||
slug="my-test-note",
|
||||
@@ -185,10 +169,10 @@ class TestNoteModel:
|
||||
created_at=datetime.now(timezone.utc).replace(tzinfo=None),
|
||||
updated_at=datetime.now(timezone.utc).replace(tzinfo=None),
|
||||
_data_dir=Path("/nonexistent"),
|
||||
title="Titled",
|
||||
)
|
||||
|
||||
# Should fall back to slug (file doesn't exist)
|
||||
assert note.title == "my-test-note"
|
||||
assert note.label == "Titled"
|
||||
assert replace(note, title=None).label == "my-test-note"
|
||||
|
||||
def test_excerpt_generation(self, tmp_path):
|
||||
"""Test excerpt generation"""
|
||||
@@ -208,8 +192,8 @@ class TestNoteModel:
|
||||
)
|
||||
|
||||
excerpt = note.excerpt
|
||||
assert len(excerpt) <= 203 # EXCERPT_LENGTH + "..."
|
||||
assert excerpt.endswith("...")
|
||||
assert len(excerpt) <= 201 # EXCERPT_LENGTH + "…"
|
||||
assert excerpt.endswith("…")
|
||||
|
||||
def test_excerpt_short_content(self, tmp_path):
|
||||
"""Test excerpt with short content (no ellipsis)"""
|
||||
@@ -259,6 +243,24 @@ class TestNoteModel:
|
||||
_data_dir=tmp_path,
|
||||
)
|
||||
|
||||
def test_excerpt_is_plain_text(self, tmp_path):
|
||||
"""No Markdown in previews, alt text or crosspost teasers (v2.16.0)"""
|
||||
note = self._note_with(
|
||||
tmp_path, "Some **bold** and a [link](https://x.example).\n\n\n\n- one\n- two")
|
||||
assert note.excerpt == "Some bold and a link. • one • two"
|
||||
|
||||
def test_hashtag_line_is_not_a_heading(self, tmp_path):
|
||||
"""'#indieweb ...' renders as text; '# Heading' still a heading (v2.16.0)"""
|
||||
note = self._note_with(tmp_path, "#indieweb is fun\n\n##two\n\n# Real heading")
|
||||
assert "<p>#indieweb is fun</p>" in note.html
|
||||
assert "<p>##two</p>" in note.html
|
||||
assert "<h1>Real heading</h1>" in note.html
|
||||
assert note.excerpt.startswith("#indieweb is fun ##two")
|
||||
|
||||
def test_hashtag_in_code_untouched(self, tmp_path):
|
||||
note = self._note_with(tmp_path, "```\n#include <x>\n```")
|
||||
assert "\\" not in note.html and "include" in note.html
|
||||
|
||||
def test_split_title(self):
|
||||
"""A '# Heading' first line is split off as the title"""
|
||||
assert split_title("# My Title\n\nBody") == ("My Title", "Body")
|
||||
@@ -266,22 +268,6 @@ class TestNoteModel:
|
||||
assert split_title("No heading\n# later") == (None, "No heading\n# later")
|
||||
assert split_title("#\nBody") == (None, "#\nBody")
|
||||
|
||||
def test_body_html_leaves_out_title(self, tmp_path):
|
||||
"""Pages show the title themselves, so the body must not repeat it"""
|
||||
note = self._note_with(tmp_path, "# My Title\n\nBody text.")
|
||||
assert "My Title" not in note.body_html
|
||||
assert "<p>Body text.</p>" in note.body_html
|
||||
assert "<h1>My Title</h1>" in note.html # html is unchanged
|
||||
|
||||
def test_body_html_untitled_matches_html(self, tmp_path):
|
||||
note = self._note_with(tmp_path, "Plain note.")
|
||||
assert note.body_html == note.html
|
||||
|
||||
def test_excerpt_leaves_out_title(self, tmp_path):
|
||||
"""Previews show the title above the excerpt, so it is not repeated"""
|
||||
note = self._note_with(tmp_path, "# Title\n\nShort content.")
|
||||
assert note.excerpt == "Short content."
|
||||
|
||||
def test_permalink(self):
|
||||
"""Test permalink generation"""
|
||||
note = Note(
|
||||
|
||||
@@ -209,10 +209,10 @@ def test_admin_status_and_test_button(app, sent):
|
||||
token = create_session("https://example.com")
|
||||
browser = app.test_client()
|
||||
browser.set_cookie("starpunk_session", token)
|
||||
page = browser.get("/admin/webmentions").get_data(as_text=True)
|
||||
page = browser.get("/admin/settings").get_data(as_text=True)
|
||||
assert "Sending like, mention, problems, reply to gotifys, ntfys at high priority" in page
|
||||
page = browser.post("/admin/notifications/test", follow_redirects=True).get_data(as_text=True)
|
||||
assert "Test notification sent" in page and sent[-1]["title"] == "StarPunk test notification"
|
||||
assert "Test notification sent" in page and "<h2>Settings</h2>" in page and sent[-1]["title"] == "StarPunk test notification"
|
||||
|
||||
|
||||
# --- Real Apprise -------------------------------------------------------------------------------------
|
||||
|
||||
@@ -68,7 +68,7 @@ def sample_notes(app):
|
||||
notes = []
|
||||
for i in range(10):
|
||||
note = create_note(
|
||||
content=f"# Test Note {i}\n\nContent for note {i}.",
|
||||
title=f"Test Note {i}", content=f"Content for note {i}.",
|
||||
published=(i < 7), # First 7 published, last 3 drafts
|
||||
)
|
||||
notes.append(note)
|
||||
@@ -316,7 +316,7 @@ class TestFeedEdgeCases:
|
||||
"""Test feed handles special characters correctly"""
|
||||
with app.app_context():
|
||||
create_note(
|
||||
content="# Test & Special <Characters>\n\n'Quotes' and \"doubles\".",
|
||||
title="Test & Special <Characters>", content="'Quotes' and \"doubles\".",
|
||||
published=True,
|
||||
)
|
||||
|
||||
@@ -330,7 +330,7 @@ class TestFeedEdgeCases:
|
||||
def test_feed_with_unicode_content(self, client, app):
|
||||
"""Test feed handles Unicode content"""
|
||||
with app.app_context():
|
||||
create_note(content="# Test Unicode 你好 🚀\n\nEmojis and ümlauts.", published=True)
|
||||
create_note(title="Test Unicode 你好 🚀", content="Emojis and ümlauts.", published=True)
|
||||
|
||||
response = client.get("/feed.xml")
|
||||
assert response.status_code == 200
|
||||
|
||||
@@ -121,6 +121,40 @@ class TestCompose:
|
||||
assert "…" in text
|
||||
|
||||
|
||||
class TestArticles:
|
||||
"""Articles are crossposted as title, teaser and link, without images (v2.16.0)"""
|
||||
|
||||
LINK = "https://blog.example.com/note/x"
|
||||
|
||||
def test_title_summary_and_link(self, app):
|
||||
with app.app_context():
|
||||
note = create_note(content="Long body " * 100, title="My Article",
|
||||
summary="The gist.", published=True)
|
||||
text = compose_text(note, self.LINK, ["IndieWeb"], 500)
|
||||
assert text == f"My Article\n\nThe gist.\n\n{self.LINK}\n\n#IndieWeb"
|
||||
|
||||
def test_without_summary_the_start_of_the_text(self, app):
|
||||
with app.app_context():
|
||||
note = create_note(content="Some *markdown* " + "word " * 100, title="T", published=True)
|
||||
title, teaser, link = compose_text(note, self.LINK, [], 5000).split("\n\n")
|
||||
assert (title, link) == ("T", self.LINK)
|
||||
assert teaser.startswith("Some markdown word") and teaser.endswith("…")
|
||||
assert len(teaser) <= 201
|
||||
|
||||
def test_edit_follows_and_no_images(self, app, server, monkeypatch):
|
||||
looked_up = []
|
||||
monkeypatch.setattr(syndication, "_media_files", lambda *a, **k: looked_up.append(a) or [])
|
||||
with app.test_request_context():
|
||||
note = create_note(content="Body", title="Before", published=True)
|
||||
select_targets(note.id, ["gotosocial"])
|
||||
process_due()
|
||||
update_note(id=note.id, title="After")
|
||||
process_due()
|
||||
assert server.statuses["1"]["status"].startswith("After\n\nBody")
|
||||
assert not server.statuses["1"].get("media_ids")
|
||||
assert looked_up == []
|
||||
|
||||
|
||||
class TestLifecycle:
|
||||
def test_publish_creates_status(self, app, server):
|
||||
note = publish(app, tags=["Test"])
|
||||
|
||||
@@ -179,12 +179,30 @@ class TestText:
|
||||
assert raw[tag["index"]["byteStart"]:tag["index"]["byteEnd"]] == b"#IndieWeb"
|
||||
assert tag["features"][0]["tag"] == "IndieWeb"
|
||||
|
||||
def test_hashtag_at_line_start_stays_a_tag(self):
|
||||
"""Not turned into a heading and lost (v2.16.0)"""
|
||||
assert plain_text("#indieweb is fun") == "#indieweb is fun"
|
||||
assert [f["features"][0]["tag"] for f in bluesky_facets(plain_text("#indieweb is fun"))] == ["indieweb"]
|
||||
|
||||
def test_fragment_in_url_is_not_a_tag(self):
|
||||
facets = bluesky_facets("see https://x.example/page#section and #42 too")
|
||||
assert [f["features"][0]["$type"] for f in facets] == ["app.bsky.richtext.facet#link"]
|
||||
|
||||
|
||||
class TestLifecycle:
|
||||
def test_article_posts_teaser_with_its_own_card(self, app, pds):
|
||||
"""An article's card is the article, even when its text links elsewhere (v2.16.0)"""
|
||||
with app.test_request_context():
|
||||
note = create_note(content="See [this](https://elsewhere.example/x) for more.",
|
||||
title="My Article", summary="The gist.", published=True)
|
||||
select_targets(note.id, ["bluesky"])
|
||||
process_due()
|
||||
record = only_record(pds)
|
||||
permalink = f"https://blog.example.com/article/{note.slug}"
|
||||
assert record["text"] == f"My Article\n\nThe gist.\n\n{permalink}"
|
||||
assert record["embed"]["external"] == {
|
||||
"uri": permalink, "title": "My Article", "description": "The gist."}
|
||||
|
||||
def test_publish_posts_with_link_card(self, app, pds):
|
||||
note = publish(app, content="Hello **Bluesky**", tags=["IndieWeb"])
|
||||
record = only_record(pds)
|
||||
|
||||
Reference in new issue
Block a user