Files
StarPunk/starpunk/routes/websub.py
T
PhilandClaude Opus 5.5 b2043286fa fix: WebSub hardening from the adversarial review (v2.10.1)
- Per-item error handling in the worker; hard time limits on requests
- Notes with photos announced after attach; feed cache/ETag follow
  content_version
- Keep failing subscriptions until lease end; retry DNS and render errors;
  hub.mode=denied for gone topics
- Spec 5.1: decode unreserved chars, echo requested topic, ignore lease and
  secret on unsubscribe, case-insensitive Content-Type, refuse empty secret
- Limits count pending requests per callback address; callback validation;
  request_id guards the verification race (migration 017)
- Render once per topic per pass; likes only push /likes; Vary: Accept

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 11:23:36 -07:00

58 lines
1.8 KiB
Python

"""
WebSub hub endpoint (v2.10.0, ADR-071)
POST /websub with hub.mode subscribe/unsubscribe, hub.topic, hub.callback,
optional hub.secret and hub.lease_seconds. Answers 202 and verifies later
(spec 5.1); errors are 4xx with a plain-text reason.
"""
from flask import Blueprint, current_app, request
from starpunk.database import get_db
from starpunk.rate_limiter import RateLimiter
from starpunk import websub
bp = Blueprint("websub", __name__)
# Subscription requests per client IP per minute
# (per gunicorn process; needs TRUSTED_PROXY=true behind a reverse proxy,
# or every client shares the proxy's address)
_limiter = RateLimiter(limit=30, window_seconds=60)
_requests = 0
def _text(message: str, status: int):
return message + "\n", status, {"Content-Type": "text/plain; charset=utf-8"}
@bp.route("/websub", methods=["POST"])
def hub():
if not websub.enabled():
return _text("WebSub is not enabled on this site", 404)
from starpunk.routes.webmention import get_client_ip
global _requests
_requests += 1
if _requests % 500 == 0:
_limiter.cleanup() # forget idle clients so memory doesn't grow
if not _limiter.is_allowed(get_client_ip()):
return _text("Too many requests", 429)
# Media types are case-insensitive (v2.10.1)
if request.mimetype != "application/x-www-form-urlencoded":
return _text("Send an application/x-www-form-urlencoded body", 400)
try:
websub.accept_subscription_request(request.form, get_db(current_app))
except websub.SubscriptionError as e:
return _text(str(e), e.status)
return _text("Accepted; the subscription will be verified", 202)
@bp.route("/websub", methods=["GET"])
def hub_info():
return _text(
"WebSub hub for this site's own feeds. Subscribe with a POST "
"(https://www.w3.org/TR/websub/).", 200)