- Connect to the address that passed the SSRF check (Host header and SNI carry the hostname, so TLS still verifies it), closing the DNS rebinding gap (spec 4.5). The webmention POST uses the same path. - Treat a change in the responses a note shows as an update and re-send its webmentions (spec 3.1.4), from validation and from admin moderation. Unchanged re-validations send nothing, so there is no ping-pong. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1.6 KiB
v2.7.2: Remaining Webmention SHOULDs
Follow-up to the v2.7.0 compliance review. Every SHOULD in the Recommendation was checked; two were not met.
4.5 DNS pinning
validate_url_for_fetch() now returns the checked address.
_pinned_request() builds each request against that IP, with the original
host in the Host header and, for https, in the sni_hostname extension.
httpcore uses sni_hostname as server_hostname with check_hostname
on, so the certificate is verified against the real hostname. Used by
safe_get() (every redirect hop) and the new safe_post() (the webmention
POST). IPv4 is preferred when a host has both families.
3.1.4 Displayed responses are an update
"If the source post displays responses... then sender SHOULD treat that as an update of the source URL and re-send any previously sent Webmentions."
note_responses_changed() re-queues a published note's previous webmentions.
It is called when:
- the worker validates a webmention and what the note shows for it changed
(
_display_state()before and after: shown or not, type, author, snippet). A re-send from the source resets the row topending; a previously valid row still counts as shown, so an unchanged re-validation sends nothing. This keeps two sites that both implement this from ping-ponging. - an admin approves, hides or deletes webmentions and a valid one changes between shown and not shown.
Tests
tests/test_webmention_spec.py: pinning (URL, Host, SNI, one lookup per
request), IPv4 preference, re-send on a new response, none on an unchanged
one, re-send on moderation changes.