phil/StarPunk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Apply correlation filter to handlers for proper multi-logger support

Browse Source 
Fixes logging errors during app initialization and in background threads.
The correlation_id filter must be applied to handlers (not just loggers)
to ensure all log records have the correlation_id attribute before
formatting occurs.

Issue: Gunicorn workers were crashing due to missing correlation_id
in logs from memory monitor and other non-request contexts.
This commit is contained in:
Phil Skentelbery
2025-11-28 16:22:12 -07:00
parent dd822a35b5
commit 10d85bb78b
1 changed files with 15 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
starpunk/__init__.py
View File

@@ -65,16 +65,8 @@ def configure_logging(app):
datefmt="%Y-%m-%d %H:%M:%S" datefmt="%Y-%m-%d %H:%M:%S"
) )
console_handler.setFormatter(formatter) # Add filter to inject correlation ID BEFORE setting formatters
file_handler.setFormatter(formatter) # This filter must be applied to handlers to work with all loggers
# Remove existing handlers and add our configured handlers
app.logger.handlers.clear()
app.logger.addHandler(console_handler)
app.logger.addHandler(file_handler)
# Add filter to inject correlation ID
# This filter will be added to ALL loggers to ensure consistency
class CorrelationIdFilter(logging.Filter): class CorrelationIdFilter(logging.Filter):
def filter(self, record): def filter(self, record):
# Get correlation ID from Flask's g object, or use fallback # Get correlation ID from Flask's g object, or use fallback
@@ -90,11 +82,21 @@ def configure_logging(app):
record.correlation_id = 'init' record.correlation_id = 'init'
return True return True
# Apply filter to Flask's app logger
correlation_filter = CorrelationIdFilter() correlation_filter = CorrelationIdFilter()
app.logger.addFilter(correlation_filter)
# Also apply to the root logger to catch all logging calls # Apply filter to handlers (not loggers) to ensure all log records have correlation_id
console_handler.addFilter(correlation_filter)
file_handler.addFilter(correlation_filter)
console_handler.setFormatter(formatter)
file_handler.setFormatter(formatter)
# Remove existing handlers and add our configured handlers
app.logger.handlers.clear()
app.logger.addHandler(console_handler)
app.logger.addHandler(file_handler)
# Also apply filter to root logger for any other loggers
root_logger = logging.getLogger() root_logger = logging.getLogger()
root_logger.addFilter(correlation_filter) root_logger.addFilter(correlation_filter)