phil/StarPunk
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Handle empty FLASK_SECRET_KEY in config (v0.9.5)

Browse Source 
os.getenv() returns empty string instead of using default when env var
is set but empty. This caused SECRET_KEY to be empty when FLASK_SECRET_KEY=""
was in .env, breaking Flask sessions/flash messages.

Now treats empty string same as unset, properly falling back to SESSION_SECRET.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Phil Skentelbery
2025-11-23 19:36:08 -07:00
parent a6f3fbaae4
commit 0d192131f3
3 changed files with 13 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
CHANGELOG.md
View File

@@ -7,6 +7,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased] ## [Unreleased]
## [0.9.5] - 2025-11-23
### Fixed
- **SECRET_KEY empty string handling**: Fixed config.py to properly handle empty `FLASK_SECRET_KEY` environment variable
- `os.getenv()` returns empty string (not None) when env var is set to `""`
- Empty string now correctly falls back to SESSION_SECRET
- Prevents Flask session/flash failures when FLASK_SECRET_KEY="" in .env file
## [0.9.4] - 2025-11-22 ## [0.9.4] - 2025-11-22
### Fixed ### Fixed

4
starpunk/__init__.py
View File

@@ -153,5 +153,5 @@ def create_app(config=None):
# Package version (Semantic Versioning 2.0.0) # Package version (Semantic Versioning 2.0.0)
# See docs/standards/versioning-strategy.md for details # See docs/standards/versioning-strategy.md for details
__version__ = "0.9.4" __version__ = "0.9.5"
__version_info__ = (0, 9, 4) __version_info__ = (0, 9, 5)

6
starpunk/config.py
View File

@@ -44,9 +44,9 @@ def load_config(app, config_override=None):
) )
# Flask secret key (uses SESSION_SECRET by default) # Flask secret key (uses SESSION_SECRET by default)
app.config["SECRET_KEY"] = os.getenv( # Note: We check for truthy value to handle empty string in .env
"FLASK_SECRET_KEY", app.config["SESSION_SECRET"] flask_secret = os.getenv("FLASK_SECRET_KEY")
) app.config["SECRET_KEY"] = flask_secret if flask_secret else app.config["SESSION_SECRET"]
# Data paths # Data paths
app.config["DATA_PATH"] = Path(os.getenv("DATA_PATH", "./data")) app.config["DATA_PATH"] = Path(os.getenv("DATA_PATH", "./data"))